Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add uno module #110

Merged
merged 12 commits into from
Mar 2, 2023
Merged

Add uno module #110

merged 12 commits into from
Mar 2, 2023

Conversation

DEVTomatoCake
Copy link
Contributor

Adds an uno module (pain)
Also changes/fixes:

  • [object Object] if a slash command from a disabled module is used
  • Users being able to use bots and themselves in Connect Four
  • Highlights the part which lead to a win in Connect Four

@SCDerox SCDerox self-requested a review February 27, 2023 20:11
Copy link
Member

@SCDerox SCDerox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When trying to play the game, some users might have an invalid card inventory. We've tried the module with four players and two users can't view their inventory.
RangeError [BUTTON_LABEL]: MessageButton label must be a string

@DEVTomatoCake
Copy link
Contributor Author

Cannot reproduce.

Copy link
Member

@SCDerox SCDerox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delays on this review. We're always working hard to respond to pull requests as fast as possible, but in this case personal reasons (school lol) lead to delays.
Nevertheless, thank you for your contribution ❤️
Your changes should be available on SCNX shortly.

@SCDerox SCDerox merged commit d099bff into ScootKit:main Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants