Fix critical schema transformation bugs and improve logging #1001
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The codebase had several critical issues that could cause runtime failures and poor production practices:
Schema Transformation Bugs: The
transform_schema
function inscrapegraphai/utils/schema_trasform.py
was vulnerable toKeyError
exceptions when processing malformed or incomplete Pydantic schemas, lacking proper error handling for missing keys.Poor Logging Practices: The
SmartScraperGraph
class usedprint()
statements instead of proper logging, which is inappropriate for production environments and headless execution.Typos: Documentation contained typos that reduced code quality ("trasfrom" instead of "transforms").
Solution
KeyError
exceptions in schema processingChanges Made
scrapegraphai/utils/schema_trasform.py
:items
,$defs
, and reference keysscrapegraphai/graphs/smart_scraper_graph.py
:print()
statements with properlogger.info()
andlogger.warning()
scrapegraphai/utils/__init__.py
:Impact
Type of Change