-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some new pages to addon docs #459
Conversation
Thank you! I guess I have few suggestions.
Footnotes |
Nice work! |
content/addons/60fps.md
Outdated
- The addon's functionality is only enabled whenever the user toggles it on by holding `alt` and clicking the green flag. The addon's functionality is toggled off every time the page is opened/refreshed. | ||
- The addon works in both the project page and the editor. | ||
- By default, the addon (when toggled on) sets the project's framerate to 60 FPS. This value can be changed in the addon's settings to an integer ranging from 31 to 240. | ||
- To prevent abuse and cheating in cloud-based multiplayer games, the addon does not work whenever there are cloud variables in a shared project. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we check whether there are cloud variables or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Hexagonl Was this removed (or the statement checked?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Hexagonl Was this removed (or the statement checked?)
It hasn't been removed. The statement is definitely incorrect - there are no references to cloud variables in the addon's code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- To prevent abuse and cheating in cloud-based multiplayer games, the addon does not work whenever there are cloud variables in a shared project. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Hexagonl Was this removed (or the statement checked?)
I verified it myself and I did remove it in my latest commit Never mind I just saw I mistakenly removed the wrong bullet point
@Hans5958 Please review again if you have some time. I don't think we should be strict here, as long as there's not any false statements being added to the docs, any page is better than no page |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be fair, I'm pretty fine to merge this since the beginning. Problem is that this is still a draft, so it is up to him if he wants this to be merged.
Before merging see: #459 (comment) |
Chose second option Co-authored-by: Hans5958 <hans5958@outlook.com>
I fixed my earlier mistake of the cloud variables in the 60fps addon, made the requested changes, and also added an additional reference in the 60fps addon. I also marked as ready to review |
I made a draft PR for now because I'd like for @Hans5958 to double check what I've made so far and ensure I'm on the right path. I'll continue making more pages and put the commits for those in this draft PR, to reduce cluttering the repository's PR history.
I'll also propose some guideline additions to the addon docs wiki in a separate issue/PR, which will be based off of stuff I've encountered while making the 60fps addon doc.
Current added addon docs