Added TryCatchStrategy #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bilge
requested changes
Dec 2, 2016
| new TryCatch( | ||
| $this->callback, | ||
| function ($e) { | ||
| if (get_class($e) === \DomainException::class) { |
There was a problem hiding this comment.
This should be an instanceof check instead of a string comparison, e.g. $e instanceof DomainException.
| { | ||
| /** @var TryCatch $tryCatch */ | ||
| $tryCatch = ( | ||
| new TryCatch( |
There was a problem hiding this comment.
This line (and everything nested below it) should be indented one level more.
| 'DomainExceptionHandled' | ||
| ) | ||
| )->setMapper(new Mapper); | ||
| self::assertSame(['foo','bar'], $tryCatch(['foo','bar'])); |
There was a problem hiding this comment.
- Prefer blank line before assertion block; here and in the previous test.
- Should be a space after each comma (
,) in array literal. Applies throughout this file.
| return $data; | ||
| }); | ||
| } | ||
| public function testTryCatch() |
There was a problem hiding this comment.
Should be blank line before starting new method.
| public function __construct(Strategy $strategy, callable $handler, $expression) | ||
| { | ||
| parent::__construct($strategy); | ||
| $this->handler = $handler; |
There was a problem hiding this comment.
Prefer blank line after parent call.
| new TryCatch( | ||
| new TryCatch( | ||
| $this->callback, | ||
| function ($e) { |
There was a problem hiding this comment.
This should be type hinted, e.g. Exception $e.
Bilge
reviewed
Dec 2, 2016
| #### Signature | ||
|
|
||
| ```php | ||
| ToList(Strategy $strategy, callable $handler, Strategy|Mapping|array|mixed $expression) |
There was a problem hiding this comment.
Looks like ToList should actually be TryCatch here.
1 similar comment
Bilge
approved these changes
Dec 5, 2016
|
Merged at #️⃣ 6d21f83. Thanks @a-barzanti for your great work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.