Update from origin #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rings (#1540) * return null if ApiError.Message is empty or whitespace * Uncomment test, which now passes
…unning the integration test "SearchForExcludedLanguage" (#1541)
* Add release notes and bump version to 0.24 * run "build FormatCode" to fix up whitespace/formatting issues * Fix failing Ssh key tests due to "validation exception". This key must be in use on github (under another user, most likely from these tests failing). Changed to a new SSH key and tweaked tests to reduce chance of a key being created and not destroyed * Assignee and Assignees cant both be specified on NewIssue. We missed this one in the PR. Marked Assignee as [Obsolete] and fixed tests to use Assignees * Fix a couple of Reactions tests that were calling the wrong client methods * Fix timeline tests - looks like the response class has changed shape a bit, it now has an Issue object in the payload and Id field isnt present (leaving Id field there in case other timeline events do use it) * Fix some following tests that require the test user to follow more than 1 other user * Unskip these Event tests now because apparently they work! * add breaking changes notes * Update ApiErrorMessageSafe to return null for empty and whitespace strings (#1540) * return null if ApiError.Message is empty or whitespace * Uncomment test, which now passes * update release notes to include PR1540 * Add "Bot" AccountType, was causing a deserialization exception when running the integration test "SearchForExcludedLanguage" (#1541) * Update to include PR1541 * add bullets to make release notes easier to read * markup additional code mentions in notes * Fix grammar fields => field
Port to .NET Core
* add a build task to run LINQPad samples * make modifications to the validation of LINQPad samples * rename the CAKE task to its original name ValidateLINQPadSamples * rename the LINQPad samples file so they get executed in ordinal order (1, 2, ..., 10 and not 1, 10, 2, ...) * remove openssl linking in TravisCI when on macOS
* add FormatCode build task * add log message to indicate we generate temp .csproj files to run the code formatter
* add .ruleset back to both Octokit and Octokit.Reactive * rename Octokit.Core.sln to Octokit.sln * remove platform-specific solution files * remove .nuspec files NuGet packaging information is now in the relevant project.json files * remove ext folder containing platform-specific assemblies * update the description of the .ruleset file we use
* add GitVersion configuration file * use beta tag for master
…eds (plus we dont actually need it anyway)
#1560) * React to change in the way the API communicates time Fixes #1558. The API used to send times as number of seconds from Unix epoch time. This has changed and is now ISO 8601. * remove openssl linking in TravisCI when on macOS # Conflicts: # .travis.yml * change appveyor config - public projects can no longer use account feeds (plus we dont actually need it anyway)
* Add merge_commit_sha to PullRequest model * Update MergeCommitSha summary
…wer event types that are failing to deserialize
…d 20 open Issues in octokit.net in attempt to more likely encounter a new EventType enum value added by github api changes
…is CanSerialize Fact needs to be updated
…nd keep the existing property init
* convert to VS2017 * rework cake.frosting build to latest cake vs2017 "template" example * fix clean task and version suffix * add arg to DotNetCorePack so it uses the correct version * fix appveyor * is there an easier way to test appveyor? * ok travis, let's do this * after reading the travis repo, this seems to be the version we want for vs201/csproj tool support * msbuild complaining about arguments - we can use defaults anyhow so remove $@ from build.sh script * add workaround for msbuild/travis, as mentioned on aspnet Mvc repo * cmon travis * perhaps tee isnt needed afterall * travis permission denied when trying to install tools in build script... i feel dirty but need to see if sudo will fix it! * could it be folder permissions of /build ? * Try 777 for NuGet.exe permissions rather than 644 * remove windows platform restriction on GitVersion call * Add a wrapper script for GitVersion on non windows * fix wrapper script name * add debug * let's see if we are running the script at all! * run mono gitversion direclty from travis.yml, for science * see if we can run bin/sh and prepend an argument to our shell script * remove echos from wrapper script * Ensure full git repo include more than 50 commits and all tags are fetched, as GitVersion was failing on TravisCI * only build netstandard framework on non windows * revert overriding the target framework when building the solution * Unix being case-sensitive, adjust app.config file name in csproj files * set FrameworkPathOverride to point to different folders on macOS and Linux * Remove NuGet.exe from the repo. On Windows, it will be installed by the Frosting bootstrapper script. On Unix/macOS, cake has smarts to look for mono- and Linux-specific executables * tidy up GitVersion logic into a GitVersionRunner class * apply workaround for osx dotnet restore "too many open files" errors * update test project references to latest official versions * doesnt seem to be a reason for overriding the implicit reference * remove extra whitespace and unused namespace
…te_constructor Remove obsoleted repository update constructor of RepositoryUpdate
Fix Issue Timeline exceptions by adding new EventInfoState values
Update ReleaseClient code samples in documentation
* add sourcelink support * Update sourcelink (2.0.2 -> 2.1.0) * Add parameter to enable source linking * tidy up the arguments with an extension method allowing an argument to be conditionally appended * Add an explicit "test sourcelink" build task and remove the MSBuild one, so we can get some build script output without needing the whole build to be in verbose logging * run sourcelink test against the NuGet packages
* (build) Updated Cake.Frosting to version 0.34.1 * Update GritVersion from 3.6.2 to 5.0.0
* Add a warning to the statistics client about caching * Simplify note about caching and direct users to the API docs Also update to use summary instead of remarks * Merge the summary sections as the 2nd section is ignored in VS * squash duplicate summary tags together * Also squash these lines
Bumps [SourceLink.Create.GitHub](https://github.com/ctaggart/SourceLink) from 2.8.2 to 2.8.3. - [Release notes](https://github.com/ctaggart/SourceLink/releases) - [Commits](ctaggart/SourceLink@2.8.2...2.8.3) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [xunit](https://github.com/xunit/xunit) from 2.2.0 to 2.4.1. - [Release notes](https://github.com/xunit/xunit/releases) - [Commits](xunit/xunit@2.2...2.4.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
* port tests to use DateTimeOffset * drop the whitespace when emitting DateTimeOffset values * tidy up stale regions
Bumps [GitHubJwt](https://github.com/adriangodong/githubjwt) from 0.0.2 to 0.0.3. - [Release notes](https://github.com/adriangodong/githubjwt/releases) - [Commits](adriangodong/githubjwt@0.0.2...0.0.3) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
* Bump NSubstitute from 3.1.0 to 4.2.1 Bumps NSubstitute from 3.1.0 to 4.2.1. Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * fix failing tests
Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 15.0.0 to 16.2.0. - [Release notes](https://github.com/microsoft/vstest/releases) - [Commits](microsoft/vstest@v15.0.0...v16.2.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
…1999) Bumps [xunit.runner.visualstudio](https://github.com/xunit/xunit) from 2.3.0-beta4-build3742 to 2.4.1. - [Release notes](https://github.com/xunit/xunit/releases) - [Commits](https://github.com/xunit/xunit/commits/2.4.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
* add support for Codecov reporting on Windows
* Add Id property to Milestone model * Exclude Riders workspace directory
…2008) * Update issue comments client to allow returning comments 'since' a specific date * Update observable issue comments client to allow returning comments 'since' a specific date * Add test cases to cover newly added methods
* Add draft PR preview header * Add Draft property to models * Update pull requests client and tests to use draft PR accept header * Update observable pull requests client and tests to use draft PR accept header * Add integration tests to create and retrieve draft pull requests
* Initial implementation of ManagementConsole - maintenance mode * Add environment var support for management console password for integration tests * Add reactive client and unit tests * Update some xmlDoc * I think this is a better way to setup the underlying baseUri on IConneciton, to achieve managemet console access rather than requiring a specific GitHubClient that cant call normal API's Instead, the management client methods can check the base Url and if it contains /api/v3/ they can set their relative endpoint Uri to include a leading "/" which will cause the /api/v3/ to be removed. * Update EnterpriseClient.cs Fix xml comments * Update IEnterpriseClient.cs Fix xml comments * Still trying to get the xmDoc perfect, thanks app veyor :) * XmlDoc'ing my way to success * Add specific test attribute for management console tests * check chronic string empty/null * Use helper's password field in test * Tidy up maintenance mode tests by using a context/destructor to manage the initial/end state of maintenance mode * make internal and tidy up URL concatenation * move GHE endpoint fixup inside ApiUrls methods * Rework request object to be the correct structure so SimpleJsonSerializer can be used to serialize it. Remove MaintenanceDate class and just pass in the Date/string for when Still need to use UrlFormEncoding rather than json in the POST body though... * Create abstract base class for FormUrlEncoded parameters (similar to existing RequetParameters) and inherit from it in UpdateMaintenanceRequest * Fix maintenance context logic - destructor should always turn maintenance OFF regardless of initial requested state * Fix xml comment * Fix Xml comment * Those pesky xml comments! * Fine, I give up! * Fix string.Format * fix bad rebase * fix failing convention tests * restore missing whitespace * writing some docs * some edits * edit
* make explicit that which previously was fine * suppress build warning
* migrate to new dotnet-format tool in build script (run on local build) * reformat code
* add support for multiple extension filters * update documentation, use ienumerable instead of ilist
* Add 'transferred' event type * Add missing force push event. Fixes #2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.