Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove obsoleted repository update constructor of RepositoryUpdate #1569

Merged
merged 5 commits into from
Mar 31, 2017
Merged

Remove obsoleted repository update constructor of RepositoryUpdate #1569

merged 5 commits into from
Mar 31, 2017

Conversation

eriawan
Copy link
Contributor

@eriawan eriawan commented Mar 20, 2017

This is a PR to remove obsoleted paramless constructor of RepositoryUpdate, it is related to issue #1568

@eriawan eriawan mentioned this pull request Mar 20, 2017
Closed
@eriawan
Copy link
Contributor Author

eriawan commented Mar 21, 2017

@shiftkey @ryangribble please review.

@eriawan
Copy link
Contributor Author

eriawan commented Mar 31, 2017

@ryangribble any updates on this? Do you want me to wait for other work in progress to be completed before approving and merging my PR?

cc @shiftkey

@shiftkey
Copy link
Member

@eriawan I don't think so. Thanks for the contribution!

@shiftkey shiftkey merged commit 8a1aa4a into octokit:master Mar 31, 2017
@eriawan
Copy link
Contributor Author

eriawan commented Mar 31, 2017

You're welcome, @shiftkey 👍

@ryangribble
Copy link
Contributor

Sorry for the delay on this one @eriawan I was planning on just running the integration tests but hadnt had time. Can pick it up on the next release anyway.

We actually need to remove all the obsolete items from -2 releases ago

@eriawan
Copy link
Contributor Author

eriawan commented Apr 2, 2017

@ryangribble no problem! 🙂

I'll try to fix the remaining obsoleted items in a separate PR. Or do you want me to wait until you finish your integration test?

thanks for the reply 👍

@ryangribble
Copy link
Contributor

No need to wait! That would be great thanks 😀

@eriawan eriawan deleted the remove_obsoleted_RepositoryUpdate_constructor branch April 2, 2017 14:20
@ryangribble
Copy link
Contributor

release_notes: Remove obsolete constructor of RepositoryUpdate request class

@nickfloyd nickfloyd added Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR and removed category: housekeeping labels Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eriawan @shiftkey @ryangribble @nickfloyd