Added rename for annotation mask as well #102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Django's QuerySet also stores annotation names in a 'annotation_select_mask' set. Not updating this set will cause a bug when the QuerySet gets cloned, and the renamed annotations will be lost.
ratoma
force-pushed
the
fix-annotations-rename-bug
branch
from
b8332a8 to
5cde392
Compare
Photonios
approved these changes
May 28, 2020
Photonios
approved these changes
Jul 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Django's QuerySet also stores annotation names in a 'annotation_select_mask'
set. Not updating this set will cause a bug when the QuerySet gets cloned,
and the renamed annotations will be lost.