Ensure bulk_upsert always returns an iterable #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Photonios
approved these changes
May 22, 2019
|
Many thanks for the contribution! Much appreciated 👍 |
|
I've released a new version on PyPi containing this fix and #78: https://pypi.org/project/django-postgres-extra/1.21a17/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The return value of
bulk_upsertis not consistent. Usually, it returns a list ofdict. However, the sanity check added in c6686f1 makes sure thatbulk_upsertreturnsNonewhen no rows (or an empty list of rows) have been passed.As a result, this pull request intends to change that by returning an empty list when the sanity check bypasses the rest of the code.