Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove footer #1952

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Remove footer #1952

merged 1 commit into from
Sep 25, 2024

Conversation

saengel
Copy link
Contributor

@saengel saengel commented Jul 3, 2024

Description

Removing the footer from where it appears on the site.

Code Changes

In each of the files listed in this PR:

  • The <Footer /> component was removed
  • The import statements importing the component were removed
  • Any logic surrounding when to render the footer (which was infrequent) was removed as well.

Notes

  • Do we want to delete the component itself (i.e. Footer.jsx), I did not do that yet, but can if we think it's right.

@saengel saengel requested a review from edamboritz July 3, 2024 15:51
@saengel saengel self-assigned this Jul 3, 2024
@saengel saengel merged commit db0e7b3 into modularization-main Sep 25, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edamboritz edamboritz edamboritz approved these changes

Assignees

@saengel saengel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saengel @edamboritz