Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated basic example and docs #66

Merged
merged 6 commits into from
Mar 26, 2021
Merged

Updated basic example and docs #66

merged 6 commits into from
Mar 26, 2021

Conversation

ukclivecox
Copy link
Contributor

@ukclivecox ukclivecox commented Mar 26, 2021

  • Removes rclone mappings
  • Adds rclone conf in basic notebook
  • Uses minio in kubernetes for basic example
  • Allows authSecretName in Kubernetes options to allow minio/auth usage

@ukclivecox ukclivecox merged commit ae29b95 into SeldonIO:master Mar 26, 2021
- widgetsnbextension==3.5.1
- wrapt==1.12.1
- zipp==3.4.1
prefix: /home/clive/anaconda3/envs/tempo-examples
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have the feeling we should skip this line.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes - will update - good catch

## Prerequisites

* rclone and conda installed.
* Run this notebook within the `seldon-examples` conda environment. Details to create this can be found [here]().
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link missing here. Also environment seems to be called name: tempo above?

logreg = LogisticRegression(C=1e5)
logreg.fit(X, y)
logreg.predict_proba(X[0:1])
with open("./artifacts/sklearn/model.joblib","wb") as f:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's the problem if folder ./artifacts/sklearn and ./artifacts/xgboost does not exist.
Probably good to add cell

%%bash
mkdir -p ./artifacts/sklearn
mkdir -p ./artifacts/xgboost

just before these.

@RafalSkolasinski
Copy link
Contributor

Further improvement to the basic notebook could be to add some ls (on local folders) and rclone lsd s3:tempo to visualise that files are first create locally and then pushed to the remote storage.



```python
classifier.deploy()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could add comment that first kubernetes deployment may take a bit of time because it will need to pull docker images.



```python
classifier.remote(payload=np.array([[1, 2, 3, 4]]))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, at this point we can also use

classifier(payload=np.array([[1, 2, 3, 4]]))

which would use the local classifier from the notebook but pre-packaged servers in the kubernetes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants