Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🚀 Feature]: Update objects name convention with prefix is Chart RELEASENAME #2109

Closed
VietND96 opened this issue Jan 23, 2024 · 9 comments · Fixed by #2134
Closed

[🚀 Feature]: Update objects name convention with prefix is Chart RELEASENAME #2109

VietND96 opened this issue Jan 23, 2024 · 9 comments · Fixed by #2134
Assignees

Comments

@VietND96
Copy link
Member

Feature and motivation

Get motivation from #2107, by default the chart RELEASENAME will be appended to all objects name to make it unique.
.name, or overrideName will be retained for setting different names if any.

Usage example

helm upgrade -i prod1 [...] selenium-grid

prod1-selenium-hub-64dff846b7-ccvb8               1/1     Running   0              2m3s
@VietND96 VietND96 self-assigned this Jan 23, 2024
Copy link

This issue is looking for contributors.

Please comment below or reach out to us through our IRC/Slack/Matrix channels if you are interested.

@Opvolger
Copy link
Contributor

I can do that :)

@VietND96
Copy link
Member Author

I can do that :)

Yes, welcome your contribution, since I have not started yet

@VietND96
Copy link
Member Author

While doing this, can you consider something

  • _helpers.tpl seems quite long now. Let's create a new tpl file, something like _name.tpl to centralize object names, naming helpers there.
  • Synchronize config key .nameOverride to override the name in each object if any. If a different key used before, we correct it to the same

For any good practices that you are referring from other charts, feel free to add :)

@Opvolger
Copy link
Contributor

Sorry, see your comments for now... Already made the change. But I can refactor it.

VietND96 pushed a commit that referenced this issue Jan 29, 2024
…ASENAME #2109 (#2120)

[feature]: Update objects name convention with prefix is Chart RELEASENAME #2109
VietND96 pushed a commit that referenced this issue Feb 12, 2024
…ASENAME #2109 (#2120)

[feature]: Update objects name convention with prefix is Chart RELEASENAME #2109
@VietND96 VietND96 linked a pull request Feb 12, 2024 that will close this issue
8 tasks
@VietND96
Copy link
Member Author

@Opvolger, I have done and merged your PR to trunk. Kindly use chart nightly to preview and hands-on to see if it works as expected

@Opvolger
Copy link
Contributor

Thnx will do

@Opvolger
Copy link
Contributor

@VietND96 it works! Deployed from trunc (multiple times) without overriding names. and tests are still green :)

Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants