Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: changing owner while creating container for download support #2069

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

VietND96
Copy link
Member

@VietND96 VietND96 commented Dec 17, 2023

Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Revert feat changing owner while creating container for download support

Motivation and Context

As discussed in #2064, If the container is started in the right way, the permissions are not an issue
Noted: images should be built with the host UID/GID

$ BUILD_ARGS="--build-arg UID=$(id -u) --build-arg GID=$(id -g)" make build

Then those can be started with --user $(id -u):$(id -g)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@VietND96 VietND96 requested a review from diemol December 17, 2023 04:08
Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
@diemol
Copy link
Member

diemol commented Dec 18, 2023

Thank you, @VietND96!

@diemol diemol merged commit 3e22a51 into SeleniumHQ:trunk Dec 18, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants