[py]: Enable co-operative multi inheritance with super() throughout
#10773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
symonk
changed the title
super() throughoutsuper() throughout
symonk
commented
Jun 15, 2022
elgatov
pushed a commit
to elgatov/selenium
that referenced
this pull request
Jun 27, 2022
…SeleniumHQ#10773) * [py]: Enable multi co-operative inheritance with `super()` throughout * [py]: Fix `_URL` param in firefox extension and indentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated most of the code to be python3.7+ syntactically, a few outliers referencing their parent class explicitly by name. This patch addresses all cases of that throughout the code. This will allow co-operative multi inheritance (leaving mro to python rather than strictly naming the class) should we/a user wish to benefit from it and make things syntactically tidier.
closes #10769