Skip to content

Conversation

pujagani
Copy link
Contributor

@pujagani pujagani commented Feb 7, 2023

This helps achieve feature parity in script pinning among different Selenium language bindings.

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

The script pinning methods as part of the driver did not use the DevTools mechanism of script pinning. The changes fix this by checking DevTools support and using the script pinning commands of DevTools.

Motivation and Context

This help achieve parity among languages. The same approach is implemented in C#, Ruby, and JS.
In future, this can be extended to use BiDi's script module command for script pinning.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

This helps achieve feature parity in script pinning among different Selenium language bindings.
@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (a31c137) 57.26% compared to head (f4a8815) 57.26%.
Report is 1 commits behind head on trunk.

❗ Current head f4a8815 differs from pull request most recent head 39d55ec. Consider uploading reports for the commit 39d55ec to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##            trunk   #11622   +/-   ##
=======================================
  Coverage   57.26%   57.26%           
=======================================
  Files          86       86           
  Lines        5335     5335           
  Branches      198      198           
=======================================
  Hits         3055     3055           
  Misses       2082     2082           
  Partials      198      198           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pujagani pujagani marked this pull request as ready for review February 7, 2023 13:33
@brodev3
Copy link

brodev3 commented Feb 11, 2023

hello, I am delighted with your work, thank you so much for the opportunities provided with your library, please tell me, are you planning to add this function to the Selenium version on python?

@diemol diemol merged commit a4beba5 into SeleniumHQ:trunk Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants