-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[java][cdp] Use devtools script pinning mechanism by default #11622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This helps achieve feature parity in script pinning among different Selenium language bindings.
Codecov ReportPatch and project coverage have no change.
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## trunk #11622 +/- ##
=======================================
Coverage 57.26% 57.26%
=======================================
Files 86 86
Lines 5335 5335
Branches 198 198
=======================================
Hits 3055 3055
Misses 2082 2082
Partials 198 198 ☔ View full report in Codecov by Sentry. |
hello, I am delighted with your work, thank you so much for the opportunities provided with your library, please tell me, are you planning to add this function to the Selenium version on python? |
This helps achieve feature parity in script pinning among different Selenium language bindings.
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
The script pinning methods as part of the driver did not use the DevTools mechanism of script pinning. The changes fix this by checking DevTools support and using the script pinning commands of DevTools.
Motivation and Context
This help achieve parity among languages. The same approach is implemented in C#, Ruby, and JS.
In future, this can be extended to use BiDi's script module command for script pinning.
Types of changes
Checklist