[java] Handle redirects inside the JdkHttpClient #11816
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diemol
reviewed
Mar 30, 2023
java/src/org/openqa/selenium/remote/http/jdk/JdkHttpClient.java
Outdated
Show resolved
Hide resolved
java/src/org/openqa/selenium/remote/http/jdk/JdkHttpClient.java
Outdated
Show resolved
Hide resolved
|
fyi, a mysterious @joerg1985 got a shout out in the State of the Union address at the Selenium Conference last week...
|
yashcho
pushed a commit
to yashcho/selenium
that referenced
this pull request
Apr 7, 2023
Handle redirects inside the JdkHttpClient Co-authored-by: Diego Molina <diemol@users.noreply.github.com>
valfirst
added a commit
to vividus-framework/vividus
that referenced
this pull request
Apr 23, 2023
Reason: mobile web tests (iPad) fail on SauceLabs. Assumption: regression issue was introduced in Selenium 4.9.0 (possible root cause: SeleniumHQ/selenium#11816)
valfirst
added a commit
to vividus-framework/vividus
that referenced
this pull request
Apr 23, 2023
Reason: mobile web tests (iPad) fail on SauceLabs. Assumption: regression issue was introduced in Selenium 4.9.0 (possible root cause: SeleniumHQ/selenium#11816)
valfirst
added a commit
to vividus-framework/vividus
that referenced
this pull request
Apr 24, 2023
Reason: mobile web tests (iPad) fail on SauceLabs. Assumption: regression issue was introduced in Selenium 4.9.0 (possible root cause: SeleniumHQ/selenium#11816)
|
This commit causes our several of our Saucelabs based builds to fail when going from Selenium 4.8.3 to 4.9.0. Running with 4.9.0 + this reverted makes everything work again. The errors are timeouts creating drivers or |
|
Can you create an issue about this, please? |
Artur-
added a commit
to vaadin/testbench
that referenced
this pull request
May 19, 2023
Artur-
added a commit
to vaadin/testbench
that referenced
this pull request
May 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to #11798 UnreachableBrowserException caused by "connection closed locally" exactly 3 minutes after session start when using JDK HttpClient.
Description
There seems to be a bug in the JDK related to redirects, see https://bugs.openjdk.org/browse/JDK-8304701
This PR will disable the redirects of the JDK HttpClient and add a custom handling of redirects.
Additionally this PR will:
I am not sure if this will fix the original issue described in #11798, so there is additional testing needed.
Types of changes
Checklist