Skip to content

Conversation

joerg1985
Copy link
Member

Description

This change will remove the io.opentelemetry dependencies where not needed.
If one must set the Context to an OpenTelemetryTracer this can be still made by using a instanceOf check and cast a Tracer to the OpenTelemetryTracer to call setOpenTelemetryContext.

Motivation and Context

Will further reduce the dependencies needed in the java client bindings.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (7497e38) 56.52% compared to head (195b8a3) 56.52%.

❗ Current head 195b8a3 differs from pull request most recent head 82350c2. Consider uploading reports for the commit 82350c2 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##            trunk   #12164   +/-   ##
=======================================
  Coverage   56.52%   56.52%           
=======================================
  Files          86       86           
  Lines        5454     5454           
  Branches      223      223           
=======================================
  Hits         3083     3083           
  Misses       2148     2148           
  Partials      223      223           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@joerg1985 joerg1985 changed the title [bazel] Limit usage of io.opentelemetry dependencies [bazel][java] Limit usage of io.opentelemetry dependencies Jun 22, 2023
@joerg1985
Copy link
Member Author

@diemol could you please have a look at this one, this will remove 13 io.opentelemetry dependencies from the client dependencies.

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @joerg1985!

@diemol diemol merged commit 41744d9 into SeleniumHQ:trunk Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants