Skip to content

Conversation

joerg1985
Copy link
Member

Description

This change will improve the handling of errors while calling the selenium manager.
The behavior is now more like the dotnet implementation, which looks better to me.

These are the changes in detail:

  • first check the exit code, parse the output only if successful
  • include the exit code and the raw output in the exception
  • replaced the exit code check code > 0 with code != 0 (dotnet does it the same way).
  • raise a exception when there was an exception calling the selenium manager (dotnet does it the same way).
  • logging was removed, as we have the exception now with the full stack and more informations

Motivation and Context

To have a better to read exception in cases like #12217 with more information to debug the issue.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@joerg1985 joerg1985 force-pushed the return-code branch 3 times, most recently from f18d7d6 to 076b116 Compare June 22, 2023 17:07
@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (a04a22f) 57.28% compared to head (40ea961) 57.28%.

❗ Current head 40ea961 differs from pull request most recent head 27dc21e. Consider uploading reports for the commit 27dc21e to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##            trunk   #12219   +/-   ##
=======================================
  Coverage   57.28%   57.28%           
=======================================
  Files          86       86           
  Lines        5487     5487           
  Branches      226      226           
=======================================
  Hits         3143     3143           
  Misses       2118     2118           
  Partials      226      226           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@diemol diemol merged commit 70c67ed into SeleniumHQ:trunk Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants