Skip to content

[dotnet] Make WebDriver.csproj file more friendly with native pack command #12235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 27, 2023
Merged

[dotnet] Make WebDriver.csproj file more friendly with native pack command #12235

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3439130
Make csproj file more friendly with native pack command
nvborisenko Jun 21, 2023
cf6e587
Merge branch 'trunk' into csproj-pack
diemol Jun 27, 2023
73d4391
Merge branch 'trunk' into csproj-pack
diemol Jun 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 49 additions & 8 deletions dotnet/src/webdriver/WebDriver.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,36 @@

<PropertyGroup>
<AssemblyTitle>WebDriver</AssemblyTitle>
<Description>Selenium WebDriver API .NET Bindings</Description>
<Company>Selenium Committers</Company>
<Copyright>Copyright © Software Freedom Conservancy 2018</Copyright>
<Product>Selenium</Product>
<Version>4.0.0</Version>
<PackageId>Selenium.WebDriver</PackageId>
<AssemblyVersion>4.0.0.0</AssemblyVersion>
<FileVersion>4.0.0.0</FileVersion>

<PackageId>Selenium.WebDriver</PackageId>
<Authors>Selenium Committers</Authors>

<Title>Selenium WebDriver</Title>

<PackageProjectUrl>https://selenium.dev</PackageProjectUrl>
<RepositoryType>GitHub</RepositoryType>
<RepositoryUrl>https://github.com/SeleniumHQ/selenium</RepositoryUrl>
<Description>
Selenium is a set of different software tools each with a different approach
to supporting browser automation. These tools are highly flexible, allowing
many options for locating and manipulating elements within a browser, and one
of its key features is the support for automating multiple browser platforms.
This package contains the .NET bindings for the concise and object-based
Selenium WebDriver API, which uses native OS-level events to manipulate the
browser, bypassing the JavaScript sandbox, and does not require the Selenium
Server to automate the browser.
</Description>
<PackageTags>selenium webdriver browser automation</PackageTags>
<PackageLicenseExpression>Apache-2.0</PackageLicenseExpression>
<PackageIconUrl>https://selenium.dev/images/selenium_logo_square_green.png</PackageIconUrl>
<PackageIcon>logo.png</PackageIcon>

<GenerateDocumentationFile>true</GenerateDocumentationFile>
</PropertyGroup>

Expand Down Expand Up @@ -47,9 +68,19 @@
<Compile Include="..\..\..\bazel-bin\dotnet\src\webdriver\cdp\**\*.cs" LinkBase="DevTools\generated" />
</ItemGroup>

<ItemGroup>
<ItemGroup Condition="$(TargetFramework) == 'netstandard2.0' or $(TargetFramework) == 'netstandard2.1' or $(TargetFramework) == 'net5.0' or $(TargetFramework) == 'net6.0'">
<PackageReference Include="Newtonsoft.Json" Version="13.0.1" />
<PackageReference Include="Microsoft.IdentityModel.Tokens" Version="6.19.0" />
</ItemGroup>

<ItemGroup Condition="$(TargetFramework) == 'net45' or $(TargetFramework) == 'net46' or $(TargetFramework) == 'net47' or $(TargetFramework) == 'net48'">
<PackageReference Include="Newtonsoft.Json" Version="13.0.1" PrivateAssets="All" />

<Reference Include="System.Net.Http" />
<Reference Include="System.IO.Compression" />
</ItemGroup>

<ItemGroup>
<PackageReference Include="Microsoft.IdentityModel.Tokens" Version="6.19.0" PrivateAssets="All"/>
</ItemGroup>

<ItemGroup>
Expand All @@ -75,13 +106,23 @@
</EmbeddedResource>
</ItemGroup>

<ItemGroup Condition="'$(TargetFramework)'!='net6.0' And '$(TargetFramework)'!='net5.0' And '$(TargetFramework)'!='netstandard2.0' And '$(TargetFramework)'!='netstandard2.1'">
<Reference Include="System.Net.Http" />
<Reference Include="System.IO.Compression" />
<ItemGroup>
<Folder Include="Remote\JsonConverters\" />
</ItemGroup>

<PropertyGroup>
<BaseSeleniumManagerPath>..\..\..\common\manager</BaseSeleniumManagerPath>
</PropertyGroup>

<ItemGroup>
<Folder Include="Remote\JsonConverters\" />
<None Include="build\Selenium.WebDriver.targets" Pack="true" PackagePath="build\" />
<None Include="build\Selenium.WebDriver.targets" Pack="true" PackagePath="buildTransitive\" />

<None Include="..\..\..\common\images\selenium_logo_small.png" Pack="true" PackagePath="\logo.png" Visible="false" />

<None Include="$(BaseSeleniumManagerPath)\linux\selenium-manager" Pack="true" PackagePath="\manager\linux" Visible="false" />
<None Include="$(BaseSeleniumManagerPath)\macos\selenium-manager" Pack="true" PackagePath="manager\macos" Visible="false" />
<None Include="$(BaseSeleniumManagerPath)\windows\selenium-manager.exe" Pack="true" PackagePath="manager\windows" Visible="false" />
</ItemGroup>

<Target Name="PreBuild" BeforeTargets="PreBuildEvent" Condition="'$(OS)' == 'Windows_NT'">
Expand Down