Skip to content

Conversation

djbrown
Copy link
Contributor

@djbrown djbrown commented Jun 21, 2023

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@CLAassistant
Copy link

CLAassistant commented Jun 21, 2023

CLA assistant check
All committers have signed the CLA.

@djbrown
Copy link
Contributor Author

djbrown commented Jun 21, 2023

This fixes the error: selenium.common.exceptions.InvalidArgumentException: Message: Invalid proxyType value: unspecified
To reproduce:

from selenium.webdriver import Firefox
from selenium.webdriver.common.proxy import Proxy
from selenium.webdriver.firefox.options import Options as FirefoxOptions

options = FirefoxOptions()
options.proxy = Proxy({'sslProxy': "my.proxy.host:8080"})
Firefox(options=options)

Copy link
Member

@titusfortner titusfortner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thanks for fixing!

@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (70c67ed) 57.28% compared to head (0f31b30) 57.28%.

❗ Current head 0f31b30 differs from pull request most recent head 51d49f2. Consider uploading reports for the commit 51d49f2 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##            trunk   #12237   +/-   ##
=======================================
  Coverage   57.28%   57.28%           
=======================================
  Files          86       86           
  Lines        5487     5487           
  Branches      226      226           
=======================================
  Hits         3143     3143           
  Misses       2118     2118           
  Partials      226      226           
Impacted Files Coverage Δ
py/selenium/webdriver/common/selenium_manager.py 64.06% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @djbrown!

@diemol diemol merged commit b49da80 into SeleniumHQ:trunk Jun 23, 2023
@djbrown djbrown deleted the patch-1 branch June 25, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants