-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
Extract original driver from decorated driver when Augmenting a driver #12248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR.
Is there a way we can reproduce the issue first to understand the fix? Maybe it can be added as a test?
I will be happy to add a test, once I'm finished with indexing the project 😂 it was running the whole night and crashed my IDE at some point... |
Make sure you mark as excluded all the |
That helped a lot! Thx |
You have *no idea how long it took me to figure out what was causing the problem... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @baflQA!
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Extract the original driver from the decorated driver.
Motivation and Context
When trying to use the Augmentor on a decorated driver, the extractRemoteWebDriver method will be executed infinitely.
Types of changes
Checklist