Skip to content

Conversation

sandeepsuryaprasad
Copy link
Contributor

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Moved all timeouts implicit_wait, page_load and script to Descriptor class.

Motivation and Context

  • By Moving all timeouts to descriptor class, all 6 properties are being replace with one descriptor class.
  • Also the internal method _convert is also eliminated since the logic to convert the value is already present in __get__ method of descriptor, which is same for all three timeouts

Types of changes

  • [] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • [] My change requires a change to the documentation.
  • [] I have updated the documentation accordingly.
  • [] I have added tests to cover my changes.
  • All new and existing tests passed.

@sandeepsuryaprasad
Copy link
Contributor Author

Now all UI as well as Unit tests are passing in my local.

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 9.09% and project coverage change: -0.33 ⚠️

Comparison is base (669fbb3) 57.44% compared to head (dc4e9b8) 57.11%.

❗ Current head dc4e9b8 differs from pull request most recent head a4fb3a9. Consider uploading reports for the commit a4fb3a9 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##            trunk   #12287      +/-   ##
==========================================
- Coverage   57.44%   57.11%   -0.33%     
==========================================
  Files          86       86              
  Lines        5369     5365       -4     
  Branches      193      193              
==========================================
- Hits         3084     3064      -20     
- Misses       2092     2108      +16     
  Partials      193      193              
Impacted Files Coverage Δ
py/selenium/webdriver/common/timeouts.py 53.65% <9.09%> (-39.68%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@diemol diemol merged commit 4468622 into SeleniumHQ:trunk Jul 6, 2023
@sandeepsuryaprasad sandeepsuryaprasad deleted the timeout_optimization branch November 24, 2024 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants