-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[py] added type hinting support to ActionChains and Alert class #12290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[py] added type hinting support to ActionChains and Alert class #12290
Conversation
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## trunk #12290 +/- ##
==========================================
+ Coverage 56.92% 57.84% +0.92%
==========================================
Files 86 86
Lines 5423 5437 +14
Branches 193 193
==========================================
+ Hits 3087 3145 +58
+ Misses 2143 2099 -44
Partials 193 193
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the missing types that @mykola-mokhnach pointed out still need doing before we can merge
I have incorporated all the comments given by @mykola-mokhnach |
The actions tests are now failing. You can run them with |
I fixed it. I forgot to initialise the functions that was taking Optional WebElement to |
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Added Type Hints to all methods in
ActionChains
andAlert
classMotivation and Context
Added Type Hints to all methods in
ActionChains
andAlert
classTypes of changes
Checklist