Skip to content

Conversation

titusfortner
Copy link
Member

@titusfortner titusfortner commented Jul 23, 2023

Status

Draft because:

Description

Sets browser location on Options class if supported (Chrome, Edge, Firefox only)

  • Errors on Chrome & Edge if browser version invalid (Not backwards compatible, but GOOD!)
  • Uses Dev/Beta/Canary/Nightly if found on system and specified by name as browser_version
  • Downloads Stable Chrome For Testing if Chrome not installed on System.

Motivation and Context

  • This ensures that the browser Selenium Manager is checking against is the one actually getting used by the driver

@titusfortner titusfortner added the C-py Python Bindings label Jul 23, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 23, 2023

Codecov Report

Patch coverage: 43.75% and project coverage change: -0.04 ⚠️

Comparison is base (1d459cd) 56.99% compared to head (4443a57) 56.95%.

❗ Current head 4443a57 differs from pull request most recent head 4f2d758. Consider uploading reports for the commit 4f2d758 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##            trunk   #12404      +/-   ##
==========================================
- Coverage   56.99%   56.95%   -0.04%     
==========================================
  Files          86       86              
  Lines        5336     5343       +7     
  Branches      193      194       +1     
==========================================
+ Hits         3041     3043       +2     
- Misses       2102     2106       +4     
- Partials      193      194       +1     
Impacted Files Coverage Δ
py/selenium/webdriver/common/selenium_manager.py 59.42% <43.75%> (-3.49%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@titusfortner titusfortner marked this pull request as ready for review July 24, 2023 16:05
@titusfortner titusfortner requested review from diemol and symonk July 24, 2023 16:06
@titusfortner titusfortner merged commit 01f65d2 into trunk Jul 24, 2023
@titusfortner titusfortner deleted the py_sm_browser branch July 24, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-py Python Bindings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants