Skip to content

Build universal macOS Selenium-Manager on CI #12455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 1, 2023
Merged

Build universal macOS Selenium-Manager on CI #12455

merged 4 commits into from
Aug 1, 2023

Conversation

p0deje
Copy link
Member

@p0deje p0deje commented Jul 31, 2023

Here is an example of a built binary - https://github.com/SeleniumHQ/selenium/actions/runs/5720210958. It's double-size as we'd expect.

$ lipo -archs ./selenium-manager
x86_64 arm64
$ du -sh selenium-manager
7.3M	selenium-manager

@p0deje p0deje mentioned this pull request Jul 31, 2023
Closed
@diemol diemol added the A-needs decision TLC needs to discuss and agree label Aug 1, 2023
diemol
diemol approved these changes Aug 1, 2023
View reviewed changes
Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good solution.

bonigarcia
bonigarcia approved these changes Aug 1, 2023
View reviewed changes
Copy link
Member

@bonigarcia bonigarcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@p0deje p0deje merged commit 8d8f2ff into trunk Aug 1, 2023
@p0deje p0deje deleted the sm-arm64 branch August 1, 2023 13:39
@leipert leipert mentioned this pull request Aug 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bonigarcia bonigarcia bonigarcia approved these changes

@diemol diemol diemol approved these changes

@titusfortner titusfortner Awaiting requested review from titusfortner

Assignees
No one assigned
Labels
A-needs decision TLC needs to discuss and agree
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@p0deje @bonigarcia @diemol