Skip to content

[py] ElementScrollBehavior fix for ie/options 4.11.0 #12462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 1, 2023
Merged

[py] ElementScrollBehavior fix for ie/options 4.11.0 #12462

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f130895
[py] ElementScrollBehavior fix for ie/options
sandeepsuryaprasad Aug 1, 2023
bc0a98d
Merge branch 'trunk' into ie-options-optimization
diemol Aug 1, 2023
c99a058
Merge branch 'trunk' into ie-options-optimization
diemol Aug 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions py/selenium/webdriver/ie/options.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,8 @@ def __set__(self, obj, value) -> None:
raise ValueError(f"{self.name} should be of type {self.expected_type.__name__}")

if self.name == "elementScrollBehavior" and value not in [
ElementScrollBehavior.TOP.value,
ElementScrollBehavior.BOTTOM.value,
ElementScrollBehavior.TOP,
ElementScrollBehavior.BOTTOM,
]:
raise ValueError("Element Scroll Behavior out of range.")
obj._options[self.name] = value
Expand Down