[dotnet] Improve nuget packages metadata

[nvborisenko]

Description

• add readme.md
• add release notes
• change bazel targets dependencies (on behalf of @shs96c)

Fixes #12709

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• I have read the contributing document.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.

[titusfortner]

why the switch from windows to linux?

[nvborisenko]

why the switch from windows to linux?

Because we can, why not. I thought linux is "cheaper".

[nvborisenko]

On linux we are getting System.IO.IOException: Read-only file system : '/home/runner/.local/share/NuGet'. So reverting this change back to run on Windows. I think we can fix it later.

[titusfortner]

If we're running rbe on Linux, I think it's good to have this run on windows anyway.

[titusfortner]

Do we need to update this section?
https://github.com/SeleniumHQ/selenium/wiki/Releasing-Selenium#net

Should I try to build a nuget on my machine from this PR before we merge it? 😄

[nvborisenko]

Releasing process should stay the same. Eventually bazel targets were renamed from //dotnet/src/webdriver:package to //dotnet/src/webdriver:webdriver-pack. @shs96c is there any reason why we did it? I's more important - can we return target names back?

[titusfortner]

Hmm, .NET tests are failing for this, @nvborisenko can you look when you get a chance?

[nvborisenko]

It was failing immediately after we applied new bazel rules for dotnet. I remember about tests, hoping @shs96c will help us, in next stage.

[titusfortner]

Things are passing on trunk. Something in this PR is an issue 😦
Can we break it up?

[nvborisenko]

Things are not passing on trunk:

ERROR: Skipping '//dotnet/test/common:chrome': no such target '//dotnet/test/common:chrome': target 'chrome' not declared in package 'dotnet/test/common' defined by D:/a/selenium/selenium/dotnet/test/common/BUILD.bazel (Tip: use `query "//dotnet/test/common:*"` to see all the targets in that package)
WARNING: Target pattern parsing failed.
ERROR: no such target '//dotnet/test/common:chrome': target 'chrome' not declared in package 'dotnet/test/common' defined by D:/a/selenium/selenium/dotnet/test/common/BUILD.bazel (Tip: use `query "//dotnet/test/common:*"` to see all the targets in that package)
INFO: Elapsed time: 21.481s
INFO: 0 processes.
FAILED: Build did NOT complete successfully (1 packages loaded)

[titusfortner]

The latest RBE on trunk is passing — https://github.com/SeleniumHQ/selenium/actions/runs/6436104331/job/17478770284
The latest CI with .NET on trunk is passing — https://github.com/SeleniumHQ/selenium/actions/runs/6435011324

[nvborisenko]

CI - RBE / Test / All RBE tests is passing now.
The latest CI with .NET on trunk is always failing, even if shown green check mark. If you follow by the link you provided, you will see:

ERROR: Skipping '//dotnet/test/common:chrome': no such target '//dotnet/test/common:chrome': target 'chrome' not declared in package 'dotnet/test/common' defined by D:/a/selenium/selenium/dotnet/test/common/BUILD.bazel (Tip: use `query "//dotnet/test/common:*"` to see all the targets in that package)

Executing tests on github actions is different topic, not related to this PR.

[titusfortner]

The latest CI with .NET on trunk is always failing

That's suboptimal

[nvborisenko]

Ok, CI build is failing, I guess something related to cache, and I have no experience in bazel even to try fixing it. In any case it is out of scope for this PR.

Last open question to move further: what is url to release notes should be (see Unresolved conversations). Thank you.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d3a167e) 56.49% compared to head (4fb9340) 56.49%.
Report is 57 commits behind head on trunk.

❗ Current head 4fb9340 differs from pull request most recent head 35ddd4a. Consider uploading reports for the commit 35ddd4a to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@           Coverage Diff           @@
##            trunk   #12873   +/-   ##
=======================================
  Coverage   56.49%   56.49%           
=======================================
  Files          86       86           
  Lines        5255     5255           
  Branches      187      187           
=======================================
  Hits         2969     2969           
  Misses       2099     2099           
  Partials      187      187           

Files	Coverage Δ
py/selenium/webdriver/common/options.py	34.31% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.