Skip to content

Conversation

bonigarcia
Copy link
Member

Description

This PR modifies the existing workflow to generate the SM binaries in CI to include the following checkbox when triggering the SM build:
image

This checkbox allows generating the SM binaries including the debug symbols, required to get a stack trace in case of an error. This will be used only on demand to troubleshoot complicated problems.

**Example of release SM binaries (checkbox disabled):
selenium-manager_linux-x64 5.22 MB
selenium-manager_macos-universal 8 MB
selenium-manager_windows-x32 4.06 MB

https://github.com/SeleniumHQ/selenium/actions/runs/6585759070

**Example of debug SM binaries (checkbox enabled):
selenium-manager_linux-x64-debug 158 MB
selenium-manager_macos-universal-debug 75.2 MB
selenium-manager_windows-x32-debug 181 MB

https://github.com/SeleniumHQ/selenium/actions/runs/6585702295

Motivation and Context

Implementation for #12887.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@bonigarcia bonigarcia added the C-rust Rust code is mostly Selenium Manager label Oct 20, 2023
@titusfortner
Copy link
Member

titusfortner commented Oct 20, 2023

Why not just have it always build both?

@bonigarcia
Copy link
Member Author

I did that since the debug artifacts are different from the usual use case. It will be generated on demand, just when a complex troubleshooting case happens. Typically, these artifacts will be downloaded by the user who experienced some problem. Since the artifacts built with GH have a retention time (6 days currently), we likely need to regenerate the build artifacts on purpose. For that, the checkbox is disabled by default (i.e., for the release), and we will trigger it with the checkbox enabled for troubleshooting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-rust Rust code is mostly Selenium Manager
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants