Skip to content

Conversation

titusfortner
Copy link
Member

@titusfortner titusfortner commented Oct 20, 2023

Description

  • checks if latest stable version is present in code and exits if not
  • downloads latest stable pdls
  • updates the Java & .NET directories and files
  • updates all references in the files themselves

Motivation and Context

Chrome is releasing more often, we need this to be easier.

This should do pretty much everything. I did a comparison of how it would handle adding 118 and it was equivalent.

Want to run this one before still (is it too aggressive to combine them?):

bazel run //scripts:pinned_browsers > common/repositories.bzl.foo
mv common/repositories.bzl.foo common/repositories.bzl
buildifier --mode fix --lint fix -r common/repositories.bzl

and run this one after:

bazel run //rb:selenium-devtools-release

@titusfortner titusfortner requested a review from diemol October 20, 2023 18:09
@titusfortner
Copy link
Member Author

I'm not certain this will grab the early stable version, so we'll have to see when it comes out.

@titusfortner titusfortner force-pushed the auto_cdp branch 2 times, most recently from 5869add to 078b69c Compare October 23, 2023 05:05
Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you, @titusfortner!

We need to add this to the release docs. And create a GitHub workflow with it? Well, I think we should merge this and fix any issues while we use the script.

@titusfortner titusfortner merged commit 8abdedd into trunk Oct 31, 2023
@titusfortner titusfortner deleted the auto_cdp branch October 31, 2023 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants