Skip to content

use subprocess.DEVNULL instead of open(os.devnull) to avoid leaking a… #13329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 19, 2023
Merged

use subprocess.DEVNULL instead of open(os.devnull) to avoid leaking a… #13329

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
58b833a
use subprocess.DEVNULL instead of open(os.devnull) to avoid leaking a…
graingert Dec 18, 2023
eda45e7
Merge branch 'trunk' into fix-unclosed-devnull
graingert Dec 18, 2023
c26eea4
Update py/selenium/webdriver/firefox/firefox_binary.py
graingert Dec 19, 2023
b8ff036
Merge branch 'trunk' into fix-unclosed-devnull
diemol Dec 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion py/selenium/webdriver/firefox/firefox_binary.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
import os
import time
from platform import system
from subprocess import DEVNULL
from subprocess import STDOUT
from subprocess import Popen

Expand All @@ -41,7 +42,7 @@ def __init__(self, firefox_path=None, log_file=None):
self._start_cmd = firefox_path
# We used to default to subprocess.PIPE instead of /dev/null, but after
# a while the pipe would fill up and Firefox would freeze.
self._log_file = log_file or open(os.devnull, "wb")
self._log_file = log_file or DEVNULL
self.command_line = None
self.platform = system().lower()
if not self._start_cmd:
Expand Down