Skip to content

Conversation

graingert
Copy link
Contributor

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@graingert
Copy link
Contributor Author

Hmm I don't have permission to run CI despite having a merged PR #13329

@titusfortner
Copy link
Member

Yes we have to approve PRs.
Can you fill out the template indicating what this does and why we want it?

@diemol
Copy link
Member

diemol commented Mar 21, 2024

I guess we can close it, we never heard back from @graingert.

@diemol diemol closed this Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants