Skip to content

Conversation

bonigarcia
Copy link
Member

@bonigarcia bonigarcia commented Jun 21, 2024

User description

Description

This PR update the Rust changelog for version 0.4.22.

Motivation and Context

Part of the release 4.22.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

PR Type

Documentation


Description

  • Updated the Rust changelog to include details for version 0.4.22.
  • Added entries for new features such as mixed output handling, driver path display in error traces, and cache path handling.
  • Mentioned the use of a pure Rust implementation for the which command and the inclusion of PATH environment for testing in CI.
  • Updated dependencies to their latest versions and included micro-optimizations.

Changes walkthrough 📝

Relevant files
Documentation
CHANGELOG.md
Update Rust changelog for version 0.4.22                                 

rust/CHANGELOG.md

  • Added changelog entries for version 0.4.22.
  • Listed new features, optimizations, and dependency updates.
  • +12/-0   

    💡 PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    Copy link
    Contributor

    PR Reviewer Guide 🔍

    ⏱️ Estimated effort to review [1-5] 1
    🧪 Relevant tests No
    🔒 Security concerns No
    ⚡ Key issues to review None

    @bonigarcia bonigarcia added C-rust Rust code is mostly Selenium Manager and removed Review effort [1-5]: 1 labels Jun 21, 2024
    Copy link
    Contributor

    PR Code Suggestions ✨

    CategorySuggestion                                                                                                                                    Score
    Best practice
    Add a date to the new version entry for consistency and clarity

    To maintain consistency with the previous version entries, consider adding a date for the
    new version 0.4.22. This helps users understand when the changes were made.

    rust/CHANGELOG.md [1-2]

    -0.4.22
    +0.4.22 - YYYY-MM-DD
     ======
     
    • Apply this suggestion
    Suggestion importance[1-10]: 7

    Why: Adding a date to the version entry in the changelog enhances clarity and maintains consistency with typical changelog formats, although the previous version shown does not include a date.

    7

    @titusfortner
    Copy link
    Member

    Ooh, I changed the script then missed this piece. Thanks for catching, I'll figure out the fix for next time.

    @titusfortner titusfortner merged commit a7e392a into trunk Jun 21, 2024
    @titusfortner titusfortner deleted the sm_release_notest_422 branch June 21, 2024 14:42
    sandeepsuryaprasad pushed a commit to sandeepsuryaprasad/selenium that referenced this pull request Oct 29, 2024
    @titusfortner titusfortner added B-docs API Docs; see other repo for website documentation and removed documentation labels Mar 30, 2025
    M1troll pushed a commit to M1troll/selenium that referenced this pull request May 14, 2025
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    B-docs API Docs; see other repo for website documentation C-rust Rust code is mostly Selenium Manager
    Projects
    Status: Done
    Development

    Successfully merging this pull request may close these issues.

    2 participants