[py] Re-add defaults for Chromium kwargs #16372
Merged
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
🔗 Related Issues
#16309
💥 What does this PR do?
This PR fixes a breaking change to the Chromium class
__init__
signature inadvertently introduced in #16309. Defaults ofNone
are re-added back as keyword argument defaults forbrowser_name
andvendor_prefix
.🔄 Types of changes
PR Type
Bug fix
Description
Re-add
None
defaults forbrowser_name
andvendor_prefix
parametersFix breaking change in ChromiumDriver
__init__
signatureRestore backwards compatibility for Chromium class initialization
Diagram Walkthrough
File Walkthrough
webdriver.py
Restore default parameter values in ChromiumDriver constructor
py/selenium/webdriver/chromium/webdriver.py
browser_name
parameter from requiredstr
to optional withNone
default
vendor_prefix
parameter from requiredstr
to optional withNone
defaultOptional
type hints for both parameters