[py] Don't write to unused pipe when no log_file #2994
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Xin the preceding checkbox, I verify that I have signed the Contributor License AgreementAs pointed out at https://stackoverflow.com/questions/40202798/is-setting-stdout-stderr-of-subprocess-popen-to-pipe-when-not-using-output-a-goo a pipe is opened and is written to but never read from per default (no log file). This is not the optimal behavior. Therefore I changed the default from
PIPEtoDEVNULL(see https://docs.python.org/3/library/subprocess.html#subprocess.DEVNULL) with a Python 2 fallback.(3rd attempt)