Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support export to Java/TestNG/ WebDriver on Selenium-IDE #326

Closed
wants to merge 1 commit into from

Conversation

rasika
Copy link

@rasika rasika commented Mar 7, 2015

Description

I suppose we can extend the support of the Selenium-IDE for TestNG / Java / WebDriver. Currently, Selenium IDE only supports only for the Java / Remote Control(RC).

Reason

The improvement suggestion was raised by the community is located at https://code.google.com/p/selenium/issues/detail?id=5492. Since use of RC is discouraged and deprecated export selenium scripts to Java/ WebDriver is highly demanded.

Benefits

End users will benefits from following two extended features;

1). Export Test Case As.. -> Java / TestNG / WebDriver

This new feature is heavily based on Java/Junit 4/WebDriver. Implemented code is tested and working as expected.

screen shot 2015-03-07 at 2 21 50 pm

2). Export Test Suite As.. -> Java / TestNG / WebDriver

This feature is implemented conformed to TestNG Test Suite documentation . According TestNG docs;

A suite is represented by one XML file. It can contain one or more tests and is defined by the tag.

Therefore, expected outcome is a testng.xml file with tags.

screen shot 2015-03-07 at 2 22 23 pm

Drawbacks

No significant drawbacks foreseen. One thing to note for this to work is that the user has to import required TestNG libraries into the user project.

I have filled & signed the SFC Individual Contributor License Agreement.

@rasika rasika changed the title Support export to Java/TestNG/ WebDriver on Selenium-IDE #5492 Support export to Java/TestNG/ WebDriver on Selenium-IDE Issue: #5492 Mar 7, 2015
@rasika rasika changed the title Support export to Java/TestNG/ WebDriver on Selenium-IDE Issue: #5492 Support export to Java/TestNG/ WebDriver on Selenium-IDE Mar 7, 2015
@andreastt
Copy link
Member

I can't think of anyone more qualified to review than @samitbadle.

@rasika
Copy link
Author

rasika commented Mar 15, 2015

ping

@samitbadle
Copy link
Contributor

Hi Rasika90,

Thank you very much for this. I had already built a TestNG exporter last year. I just managed to find it and pushed it the old Google code repository. I will push it here once I have write access to this repository. @andreastt can someone do the needful? Once it is pushed, I would appreciate your help to see if I have missed anything.

Cheers,
Samit

@samitbadle
Copy link
Contributor

The commit id is 0cdc1b9

@rasika
Copy link
Author

rasika commented Mar 16, 2015

Hi samitbadle,

Thank you for the information. commit looks good.

Thank you

@rasika rasika closed this Mar 16, 2015
var str = 'new String[] {';
for (var i = 0; i < value.length; i++) {
str += string(value[i]);
if (i < value.length - 1) str += ", ";

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check the formatting here.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in #7e0de8f.

this.suiteExtension = ".xml";
this.webdriver = true;

WDAPI.Driver = function() {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatting issues ->
function() { should be like this -> function () {

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in #7e0de8f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants