-
-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support export to Java/TestNG/ WebDriver on Selenium-IDE #326
Conversation
I can't think of anyone more qualified to review than @samitbadle. |
ping |
Hi Rasika90, Thank you very much for this. I had already built a TestNG exporter last year. I just managed to find it and pushed it the old Google code repository. I will push it here once I have write access to this repository. @andreastt can someone do the needful? Once it is pushed, I would appreciate your help to see if I have missed anything. Cheers, |
The commit id is 0cdc1b9 |
Hi samitbadle, Thank you for the information. commit looks good. Thank you |
var str = 'new String[] {'; | ||
for (var i = 0; i < value.length; i++) { | ||
str += string(value[i]); | ||
if (i < value.length - 1) str += ", "; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check the formatting here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in #7e0de8f.
this.suiteExtension = ".xml"; | ||
this.webdriver = true; | ||
|
||
WDAPI.Driver = function() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Formatting issues ->
function() { should be like this -> function () {
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in #7e0de8f.
Description
I suppose we can extend the support of the Selenium-IDE for
TestNG / Java / WebDriver
. Currently, Selenium IDE only supports only for theJava / Remote Control(RC)
.Reason
The improvement suggestion was raised by the community is located at https://code.google.com/p/selenium/issues/detail?id=5492. Since use of RC is discouraged and deprecated export selenium scripts to Java/ WebDriver is highly demanded.
Benefits
End users will benefits from following two extended features;
1). Export Test Case As.. -> Java / TestNG / WebDriver
This new feature is heavily based on
Java/Junit 4/WebDriver
. Implemented code is tested and working as expected.2). Export Test Suite As.. -> Java / TestNG / WebDriver
This feature is implemented conformed to TestNG Test Suite documentation . According TestNG docs;
Therefore, expected outcome is a
testng.xml
file with tags.Drawbacks
No significant drawbacks foreseen. One thing to note for this to work is that the user has to import required TestNG libraries into the user project.
I have filled & signed the SFC Individual Contributor License Agreement.