Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[python]Firefox 20.0.1 on Windows "TypeError: environment can only contain string" problem #54

Closed
wants to merge 1 commit into from
Closed

[python]Firefox 20.0.1 on Windows "TypeError: environment can only contain string" problem #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion py/selenium/webdriver/firefox/firefox_profile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ def path(self):
"""
Gets the profile directory that is currently being used
"""
return self.profile_dir
return str(self.profile_dir)

@property
def port(self):
Expand Down
5 changes: 5 additions & 0 deletions py/test/selenium/webdriver/firefox/ff_profile_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,11 @@ def test_that_unicode_prefs_are_written_in_the_correct_format(self):
break
fp.close()

def testThePathOfTheTemporaryProfileShouldNotBeUnicode(self):
#firefox 20.0.1 can not take unicode string in env
existingProfile = webdriver.FirefoxProfile()
profile = webdriver.FirefoxProfile(existingProfile.path)
assert(type(profile.path) is str)

def test_that_we_delete_the_profile(self):
path = self.driver.firefox_profile.path
Expand Down