Skip to content

Conversation

@carlosgcampos
Copy link
Contributor

@carlosgcampos carlosgcampos commented Sep 6, 2018

For the WPE port of WebKit


This change is Reviewable

For the WPE port of WebKit
@lmtierney lmtierney added the C-py Python Bindings label Sep 18, 2018
@lmtierney
Copy link
Member

Are we going to keep adding lesser-used webdrivers to the selenium code base? A quick look at the code looks like you could easily just subclass the WebKitGTK Options and pass it directly to the WebKitGTK webdriver.

@lmtierney lmtierney added the J-awaiting answer Question asked of user; a reply moves it to triage again label Sep 18, 2018
@carlosgcampos
Copy link
Contributor Author

Well, WPE is not used for general purpose desktop browsers, but it's used in a lot of embedded devices. The driver is similar to the WebKitGTK+ one, but all driver impls are quite similar to each other. Problem of subclassing is that options of WebKitGTK+ might not make sense in WPE (and the other way around). like for example the overlay scrollbars option. Anyway, I don't plan to add more drivers :-)

@aperezdc
Copy link

Ping. Any chance of having this merged?

@p0deje p0deje added A-needs decision TLC needs to discuss and agree and removed J-awaiting answer Question asked of user; a reply moves it to triage again labels Oct 15, 2018
@CLAassistant
Copy link

CLAassistant commented Nov 23, 2019

CLA assistant check
All committers have signed the CLA.

@AutomatedTester AutomatedTester merged commit 0d7e57a into SeleniumHQ:master Mar 6, 2020
@carlosgcampos carlosgcampos deleted the wpe branch March 11, 2020 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-needs decision TLC needs to discuss and agree C-py Python Bindings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants