Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[py] Add WPEWebKit driver #6375

Merged
merged 2 commits into from Mar 6, 2020
Merged

[py] Add WPEWebKit driver #6375

merged 2 commits into from Mar 6, 2020

Conversation

@carlosgcampos
Copy link
Contributor

@carlosgcampos carlosgcampos commented Sep 6, 2018

For the WPE port of WebKit


This change is Reviewable

For the WPE port of WebKit
@lmtierney lmtierney added the C-py label Sep 18, 2018
@lmtierney
Copy link
Member

@lmtierney lmtierney commented Sep 18, 2018

Are we going to keep adding lesser-used webdrivers to the selenium code base? A quick look at the code looks like you could easily just subclass the WebKitGTK Options and pass it directly to the WebKitGTK webdriver.

@carlosgcampos
Copy link
Contributor Author

@carlosgcampos carlosgcampos commented Sep 18, 2018

Well, WPE is not used for general purpose desktop browsers, but it's used in a lot of embedded devices. The driver is similar to the WebKitGTK+ one, but all driver impls are quite similar to each other. Problem of subclassing is that options of WebKitGTK+ might not make sense in WPE (and the other way around). like for example the overlay scrollbars option. Anyway, I don't plan to add more drivers :-)

@aperezdc
Copy link

@aperezdc aperezdc commented Oct 15, 2018

Ping. Any chance of having this merged?

@CLAassistant
Copy link

@CLAassistant CLAassistant commented Nov 23, 2019

CLA assistant check
All committers have signed the CLA.

@AutomatedTester AutomatedTester merged commit 0d7e57a into SeleniumHQ:master Mar 6, 2020
1 of 2 checks passed
@carlosgcampos carlosgcampos deleted the wpe branch Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants