Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[py] Add WPEWebKit driver #6375

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@carlosgcampos
Copy link
Contributor

commented Sep 6, 2018

For the WPE port of WebKit


This change is Reviewable

[py] Add WPEWebKit driver
For the WPE port of WebKit

@lmtierney lmtierney added the C-py label Sep 18, 2018

@lmtierney

This comment has been minimized.

Copy link
Member

commented Sep 18, 2018

Are we going to keep adding lesser-used webdrivers to the selenium code base? A quick look at the code looks like you could easily just subclass the WebKitGTK Options and pass it directly to the WebKitGTK webdriver.

@carlosgcampos

This comment has been minimized.

Copy link
Contributor Author

commented Sep 18, 2018

Well, WPE is not used for general purpose desktop browsers, but it's used in a lot of embedded devices. The driver is similar to the WebKitGTK+ one, but all driver impls are quite similar to each other. Problem of subclassing is that options of WebKitGTK+ might not make sense in WPE (and the other way around). like for example the overlay scrollbars option. Anyway, I don't plan to add more drivers :-)

@aperezdc

This comment has been minimized.

Copy link

commented Oct 15, 2018

Ping. Any chance of having this merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.