chore(debug): remove debug from builds #2058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2058 +/- ##
=======================================
Coverage 99.76% 99.76%
=======================================
Files 148 148
Lines 2561 2561
=======================================
Hits 2555 2555
Misses 6 6
Continue to review full report at Codecov.
|
layershifter
force-pushed
the
chore/remove-debug
branch
from
d42072d
to
9dfd668
Compare
|
AHHH!! Thanks so much for this. This has been a nagging nightmare for me. Very happy to see this. |
|
Released in |
layershifter
added a commit
that referenced
this pull request
Sep 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1238.
Why?
This issue is one of the most longstanding problems. We tried to solve it in #1237 and #1663, but solution wasn't elegant. Levi suggested to use a babel plugin there.
I've tried multiple plugins and selected
babel-plugin-filter-imports. I've done there big work and now we can see it there 😄This PR:
debugfrom our buildsdebugto dev deps