Change "muncodes" setting from string-array to simple string #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change muncode representation in settings from string array to simple string with commas
The old format uses a string array to represent the municipality-code list. The new format is a simple comma delimited text. The submission add code to automatically change the old format to the new format
|
Hi @bvthomsen Thank you very much! @GregersP could you try this one out in Ubuntu? I will test it in OSX for what it is worth :-) |
Closed
|
Does this still need testing on Ubuntu? With #24 fixed and all? |
|
It works - as commented on the issue 👍 |
|
I will close this pull request noting that it demonstrated the issue clearly and showed a solution which the final fix was sketched over. Thank you @bvthomsen |
|
Ok for me :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of a string-array for setting "muncodes" is the cause of some trouble ( #24 ) in septima - master branch.
This pull request remedy this by changing the "muncodes" setting to a simple string.
This is not tested on a linux- or mac- based pc, but works on Windows - both with settings in registry and settings saved in a ini-file (-configpath parametr used).
Further, the patch will convert existing settings to the new format (using a butt ugly hack)