Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "muncodes" setting from string-array to simple string #26

Closed
wants to merge 2 commits into from

Conversation

bvthomsen
Copy link

The use of a string-array for setting "muncodes" is the cause of some trouble ( #24 ) in septima - master branch.

This pull request remedy this by changing the "muncodes" setting to a simple string.

This is not tested on a linux- or mac- based pc, but works on Windows - both with settings in registry and settings saved in a ini-file (-configpath parametr used).

Further, the patch will convert existing settings to the new format (using a butt ugly hack)

Change muncode representation in settings from string array to simple
string with commas
The old format uses a string array to represent the municipality-code
list. The new format is a simple comma delimited text. The submission
add code to automatically change the old format to the new format
@AsgerPetersen
Copy link
Contributor

Hi @bvthomsen

Thank you very much!

@GregersP could you try this one out in Ubuntu? I will test it in OSX for what it is worth :-)

@GregersP
Copy link

Does this still need testing on Ubuntu? With #24 fixed and all?
If so I'll give it a spin :)

@AsgerPetersen
Copy link
Contributor

@GregersP no. Could you please test if the fix in master for #24 also works on Ubuntu?

@GregersP
Copy link

It works - as commented on the issue 👍

@AsgerPetersen
Copy link
Contributor

I will close this pull request noting that it demonstrated the issue clearly and showed a solution which the final fix was sketched over. Thank you @bvthomsen

@bvthomsen
Copy link
Author

Ok for me :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants