Skip to content

Commit 024fd9b

Browse files
committed
LibWeb: Fix HTML injection on FrameLoader error page
Small regression introduced by 3857148, we still have to escape HTML entities.
1 parent 696f23d commit 024fd9b

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

Userland/Libraries/LibWeb/Loader/FrameLoader.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -229,8 +229,8 @@ void FrameLoader::load_error_page(const URL& failed_url, const String& error)
229229
VERIFY(!data.is_null());
230230
StringBuilder builder;
231231
SourceGenerator generator { builder };
232-
generator.set("failed_url", failed_url.to_string());
233-
generator.set("error", error);
232+
generator.set("failed_url", escape_html_entities(failed_url.to_string()));
233+
generator.set("error", escape_html_entities(error));
234234
generator.append(data);
235235
auto document = HTML::parse_html_document(generator.as_string_view(), failed_url, "utf-8");
236236
VERIFY(document);

0 commit comments

Comments
 (0)