LibJS: Make assertion in BindThisValue mirror the spec exactly :^)

awesomekling · awesomekling · commit 06787410addd · 2021-06-25T20:38:43.000+02:00
diff --git a/Userland/Libraries/LibJS/Runtime/FunctionEnvironmentRecord.cpp b/Userland/Libraries/LibJS/Runtime/FunctionEnvironmentRecord.cpp
@@ -70,7 +70,7 @@ Value FunctionEnvironmentRecord::get_this_binding(GlobalObject& global_object) c
 // 9.1.1.3.1 BindThisValue ( V ), https://tc39.es/ecma262/#sec-bindthisvalue
 Value FunctionEnvironmentRecord::bind_this_value(GlobalObject& global_object, Value this_value)
 {
-    VERIFY(has_this_binding());
+    VERIFY(this_binding_status() != ThisBindingStatus::Lexical);
     if (this_binding_status() == ThisBindingStatus::Initialized) {
         vm().throw_exception<ReferenceError>(global_object, ErrorType::ThisIsAlreadyInitialized);
         return {};

Original file line number	Diff line number	Diff line change
`@@ -70,7 +70,7 @@ Value FunctionEnvironmentRecord::get_this_binding(GlobalObject& global_object) c`
`70`	`70`	`// 9.1.1.3.1 BindThisValue ( V ), https://tc39.es/ecma262/#sec-bindthisvalue`
`71`	`71`	`Value FunctionEnvironmentRecord::bind_this_value(GlobalObject& global_object, Value this_value)`
`72`	`72`	`{`
`73`		`- VERIFY(has_this_binding());`
	`73`	`+ VERIFY(this_binding_status() != ThisBindingStatus::Lexical);`
`74`	`74`	`if (this_binding_status() == ThisBindingStatus::Initialized) {`
`75`	`75`	`vm().throw_exception<ReferenceError>(global_object, ErrorType::ThisIsAlreadyInitialized);`
`76`	`76`	`return {};`