Skip to content

Commit 1768743

Browse files
committed
WindowServer: Redraw menu items after client updates them somehow
This fixes an issue where the undo/redo actions in TextEditor only updated once you hovered over them.
1 parent 42435ce commit 1768743

File tree

2 files changed

+4
-0
lines changed

2 files changed

+4
-0
lines changed

Userland/Services/WindowServer/ConnectionFromClient.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -191,6 +191,8 @@ void ConnectionFromClient::update_menu_item(i32 menu_id, i32 identifier, [[maybe
191191
menu_item->set_default(is_default);
192192
if (checkable)
193193
menu_item->set_checked(checked);
194+
195+
menu.redraw(*menu_item);
194196
}
195197

196198
void ConnectionFromClient::remove_menu_item(i32 menu_id, i32 identifier)

Userland/Services/WindowServer/Menu.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -106,6 +106,8 @@ void Menu::redraw()
106106

107107
void Menu::redraw(MenuItem const& menu_item)
108108
{
109+
if (!menu_window())
110+
return;
109111
draw(menu_item);
110112
menu_window()->invalidate(menu_item.rect());
111113
}

0 commit comments

Comments
 (0)