Skip to content

Commit 2249e79

Browse files
nicoawesomekling
authored andcommitted
LibPDF: Add two FIXMEs
1 parent d451197 commit 2249e79

File tree

2 files changed

+4
-0
lines changed

2 files changed

+4
-0
lines changed

Userland/Libraries/LibPDF/Encoding.cpp

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,9 @@ PDFErrorOr<NonnullRefPtr<Encoding>> Encoding::from_object(Document* document, No
2323
auto name = obj->cast<NameObject>()->name();
2424
if (name == "StandardEncoding")
2525
return standard_encoding();
26+
27+
// FIXME: MacExpertEncoding
28+
2629
if (name == "MacRomanEncoding")
2730
return mac_encoding();
2831
if (name == "WinAnsiEncoding")

Userland/Libraries/LibPDF/Fonts/CFF.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -388,6 +388,7 @@ PDFErrorOr<Vector<DeprecatedFlyString>> CFF::parse_charset(Reader&& reader, size
388388
auto resolve = [](SID sid) {
389389
if (sid < s_cff_builtin_names.size())
390390
return DeprecatedFlyString(s_cff_builtin_names[sid]);
391+
// FIXME: Read from String INDEX instead.
391392
dbgln("Cound't find string for SID {}, going with space", sid);
392393
return DeprecatedFlyString("space");
393394
};

0 commit comments

Comments
 (0)