Skip to content

Commit 24f9749

Browse files
kalenikaliaksandrawesomekling
authored andcommitted
LibWeb: Delete unused create_a_new_browsing_context_group()
Became unused after introducing create_a_new_browsing_context_group_and_document() used in navigables
1 parent 6665f0d commit 24f9749

File tree

2 files changed

+0
-19
lines changed

2 files changed

+0
-19
lines changed

Userland/Libraries/LibWeb/HTML/BrowsingContextGroup.cpp

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -52,23 +52,6 @@ auto BrowsingContextGroup::create_a_new_browsing_context_group_and_document(Page
5252
return BrowsingContextGroupAndDocument { group, document };
5353
}
5454

55-
// https://html.spec.whatwg.org/multipage/browsers.html#creating-a-new-browsing-context-group
56-
JS::NonnullGCPtr<BrowsingContextGroup> BrowsingContextGroup::create_a_new_browsing_context_group(Web::Page& page)
57-
{
58-
// 1. Let group be a new browsing context group.
59-
// 2. Append group to the user agent's browsing context group set.
60-
auto group = Bindings::main_thread_vm().heap().allocate_without_realm<BrowsingContextGroup>(page);
61-
62-
// 3. Let browsingContext be the result of creating a new browsing context with null, null, and group.
63-
auto browsing_context = BrowsingContext::create_a_new_browsing_context(page, nullptr, nullptr, *group);
64-
65-
// 4. Append browsingContext to group.
66-
group->append(move(browsing_context));
67-
68-
// 5. Return group.
69-
return *group;
70-
}
71-
7255
// https://html.spec.whatwg.org/multipage/browsers.html#bcg-append
7356
void BrowsingContextGroup::append(BrowsingContext& browsing_context)
7457
{

Userland/Libraries/LibWeb/HTML/BrowsingContextGroup.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,6 @@ class BrowsingContextGroup final : public JS::Cell {
1818
JS_CELL(BrowsingContextGroup, JS::Cell);
1919

2020
public:
21-
static JS::NonnullGCPtr<BrowsingContextGroup> create_a_new_browsing_context_group(Page&);
22-
2321
struct BrowsingContextGroupAndDocument {
2422
JS::NonnullGCPtr<HTML::BrowsingContextGroup> browsing_context;
2523
JS::NonnullGCPtr<DOM::Document> document;

0 commit comments

Comments
 (0)