Meta+Userland: Pass Gfx::IntSize by value

Just two ints like Gfx::IntPoint.

Author: MacDue

Meta/Lagom/Tools/CodeGenerators/IPCCompiler/main.cpp

@@ -69,7 +69,7 @@ static bool is_primitive_type(DeprecatedString const& type)
 static bool is_simple_type(DeprecatedString const& type)
 {
     // Small types that it makes sense just to pass by value.
-    return type.is_one_of("Gfx::Color", "Gfx::IntPoint", "Gfx::FloatPoint");
+    return type.is_one_of("Gfx::Color", "Gfx::IntPoint", "Gfx::FloatPoint", "Gfx::IntSize");
 }
 
 static bool is_primitive_or_simple_type(DeprecatedString const& type)

Userland/Applications/Browser/BrowserWindow.cpp

@@ -698,7 +698,7 @@ void BrowserWindow::broadcast_window_position(Gfx::IntPoint position)
     });
 }
 
-void BrowserWindow::broadcast_window_size(Gfx::IntSize const& size)
+void BrowserWindow::broadcast_window_size(Gfx::IntSize size)
 {
     tab_widget().for_each_child_of_type<Browser::Tab>([&](auto& tab) {
         tab.window_size_changed(size);

Userland/Applications/Browser/BrowserWindow.h

@@ -46,7 +46,7 @@ class BrowserWindow final : public GUI::Window
     void proxy_mappings_changed();
 
     void broadcast_window_position(Gfx::IntPoint);
-    void broadcast_window_size(Gfx::IntSize const&);
+    void broadcast_window_size(Gfx::IntSize);
 
 private:
     explicit BrowserWindow(CookieJar&, URL);

Userland/Applications/Browser/Tab.cpp

@@ -277,7 +277,7 @@ Tab::Tab(BrowserWindow& window)
         return this->window().position();
     };
 
-    view().on_resize_window = [this](Gfx::IntSize const& size) {
+    view().on_resize_window = [this](Gfx::IntSize size) {
         this->window().resize(size);
         return this->window().size();
     };
@@ -619,7 +619,7 @@ void Tab::window_position_changed(Gfx::IntPoint position)
     m_web_content_view->set_window_position(position);
 }
 
-void Tab::window_size_changed(Gfx::IntSize const& size)
+void Tab::window_size_changed(Gfx::IntSize size)
 {
     m_web_content_view->set_window_size(size);
 }

Userland/Applications/Browser/Tab.h

@@ -57,7 +57,7 @@ class Tab final : public GUI::Widget {
     void action_left(GUI::Action&);
 
     void window_position_changed(Gfx::IntPoint);
-    void window_size_changed(Gfx::IntSize const&);
+    void window_size_changed(Gfx::IntSize);
 
     Function<void(DeprecatedString const&)> on_title_change;
     Function<void(const URL&)> on_tab_open_request;

Userland/Applications/PixelPaint/CreateNewImageDialog.h

@@ -14,7 +14,7 @@ class CreateNewImageDialog final : public GUI::Dialog {
     C_OBJECT(CreateNewImageDialog)
 
 public:
-    Gfx::IntSize const& image_size() const { return m_image_size; }
+    Gfx::IntSize image_size() const { return m_image_size; }
     DeprecatedString const& image_name() const { return m_image_name; }
 
 private:

Userland/Applications/PixelPaint/CreateNewLayerDialog.cpp

@@ -13,7 +13,7 @@
 
 namespace PixelPaint {
 
-CreateNewLayerDialog::CreateNewLayerDialog(Gfx::IntSize const& suggested_size, GUI::Window* parent_window)
+CreateNewLayerDialog::CreateNewLayerDialog(Gfx::IntSize suggested_size, GUI::Window* parent_window)
     : Dialog(parent_window)
 {
     set_title("Create new layer");

Userland/Applications/PixelPaint/CreateNewLayerDialog.h

@@ -14,11 +14,11 @@ class CreateNewLayerDialog final : public GUI::Dialog {
     C_OBJECT(CreateNewLayerDialog);
 
 public:
-    Gfx::IntSize const& layer_size() const { return m_layer_size; }
+    Gfx::IntSize layer_size() const { return m_layer_size; }
     DeprecatedString const& layer_name() const { return m_layer_name; }
 
 private:
-    CreateNewLayerDialog(Gfx::IntSize const& suggested_size, GUI::Window* parent_window);
+    CreateNewLayerDialog(Gfx::IntSize suggested_size, GUI::Window* parent_window);
 
     Gfx::IntSize m_layer_size;
     DeprecatedString m_layer_name;

Userland/Applications/PixelPaint/Image.cpp

@@ -24,7 +24,7 @@
 
 namespace PixelPaint {
 
-ErrorOr<NonnullRefPtr<Image>> Image::try_create_with_size(Gfx::IntSize const& size)
+ErrorOr<NonnullRefPtr<Image>> Image::try_create_with_size(Gfx::IntSize size)
 {
     VERIFY(!size.is_empty());
 
@@ -34,7 +34,7 @@ ErrorOr<NonnullRefPtr<Image>> Image::try_create_with_size(Gfx::IntSize const& si
     return adopt_nonnull_ref_or_enomem(new (nothrow) Image(size));
 }
 
-Image::Image(Gfx::IntSize const& size)
+Image::Image(Gfx::IntSize size)
     : m_size(size)
     , m_selection(*this)
 {
@@ -548,7 +548,7 @@ Optional<Gfx::IntRect> Image::nonempty_content_bounding_rect() const
     return bounding_rect;
 }
 
-void Image::resize(Gfx::IntSize const& new_size, Gfx::Painter::ScalingMode scaling_mode)
+void Image::resize(Gfx::IntSize new_size, Gfx::Painter::ScalingMode scaling_mode)
 {
     float scale_x = 1.0f;
     float scale_y = 1.0f;

Userland/Applications/PixelPaint/Image.h

@@ -46,7 +46,7 @@ class ImageClient {
 
 class Image : public RefCounted<Image> {
 public:
-    static ErrorOr<NonnullRefPtr<Image>> try_create_with_size(Gfx::IntSize const&);
+    static ErrorOr<NonnullRefPtr<Image>> try_create_with_size(Gfx::IntSize);
     static ErrorOr<NonnullRefPtr<Image>> try_create_from_pixel_paint_json(JsonObject const&);
     static ErrorOr<NonnullRefPtr<Image>> try_create_from_bitmap(NonnullRefPtr<Gfx::Bitmap>);
 
@@ -63,7 +63,7 @@ class Image : public RefCounted<Image> {
     Layer const& layer(size_t index) const { return m_layers.at(index); }
     Layer& layer(size_t index) { return m_layers.at(index); }
 
-    Gfx::IntSize const& size() const { return m_size; }
+    Gfx::IntSize size() const { return m_size; }
     Gfx::IntRect rect() const { return { {}, m_size }; }
 
     void add_layer(NonnullRefPtr<Layer>);
@@ -100,14 +100,14 @@ class Image : public RefCounted<Image> {
     void flip(Gfx::Orientation orientation);
     void rotate(Gfx::RotationDirection direction);
     void crop(Gfx::IntRect const& rect);
-    void resize(Gfx::IntSize const& new_size, Gfx::Painter::ScalingMode scaling_mode);
+    void resize(Gfx::IntSize new_size, Gfx::Painter::ScalingMode scaling_mode);
 
     Optional<Gfx::IntRect> nonempty_content_bounding_rect() const;
 
     Color color_at(Gfx::IntPoint point) const;
 
 private:
-    explicit Image(Gfx::IntSize const&);
+    explicit Image(Gfx::IntSize);
 
     void did_change(Gfx::IntRect const& modified_rect = {});
     void did_change_rect(Gfx::IntRect const& modified_rect = {});