Skip to content

Commit 28bc3a7

Browse files
Lubrsilinusg
authored andcommitted
LibWeb: Remove old assertion in host_enqueue_promise_job context hack
We no longer need to pull a global object from somewhere to push an execution context onto the stack, so the assertion no longer makes sense.
1 parent a0c41fc commit 28bc3a7

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

Userland/Libraries/LibWeb/Bindings/MainThreadVM.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -247,10 +247,7 @@ JS::VM& main_thread_vm()
247247
} else {
248248
// FIXME: We need to setup a dummy execution context in case a JS::NativeFunction is called when processing the job.
249249
// This is because JS::NativeFunction::call excepts something to be on the execution context stack to be able to get the caller context to initialize the environment.
250-
// Since this requires pushing an execution context onto the stack, it also requires a global object. The only thing we can get a global object from in this case is the script or module.
251-
// To do this, we must assume script or module is not Empty. We must also assume that it is a Script Record for now as we don't currently run modules.
252250
// Do note that the JS spec gives _no_ guarantee that the execution context stack has something on it if HostEnqueuePromiseJob was called with a null realm: https://tc39.es/ecma262/#job-preparedtoevaluatecode
253-
VERIFY(script_or_module.has<JS::NonnullGCPtr<JS::Script>>());
254251
dummy_execution_context = JS::ExecutionContext { vm->heap() };
255252
dummy_execution_context->script_or_module = script_or_module;
256253
vm->push_execution_context(dummy_execution_context.value());

0 commit comments

Comments
 (0)