LanguageServers/Cpp: Handle autocomplete request on an empty line

itamar8910 · awesomekling · commit 2da5ecba41ca · 2021-02-13T19:50:09.000+01:00
diff --git a/Userland/DevTools/HackStudio/LanguageServers/Cpp/ParserAutoComplete.cpp b/Userland/DevTools/HackStudio/LanguageServers/Cpp/ParserAutoComplete.cpp
@@ -97,8 +97,7 @@ ParserAutoComplete::DocumentData::DocumentData(String&& _text)
 
 Vector<GUI::AutocompleteProvider::Entry> ParserAutoComplete::get_suggestions(const String& file, const GUI::TextPosition& autocomplete_position)
 {
-    ASSERT(autocomplete_position.column() > 0);
-    Cpp::Position position { autocomplete_position.line(), autocomplete_position.column() - 1 };
+    Cpp::Position position { autocomplete_position.line(), autocomplete_position.column() > 0 ? autocomplete_position.column() - 1 : 0 };
 
     VERBOSE("ParserAutoComplete position {}:{}", position.line, position.column);
 

Original file line number	Diff line number	Diff line change
`@@ -97,8 +97,7 @@ ParserAutoComplete::DocumentData::DocumentData(String&& _text)`
`97`	`97`
`98`	`98`	`Vector<GUI::AutocompleteProvider::Entry> ParserAutoComplete::get_suggestions(const String& file, const GUI::TextPosition& autocomplete_position)`
`99`	`99`	`{`
`100`		`- ASSERT(autocomplete_position.column() > 0);`
`101`		`- Cpp::Position position { autocomplete_position.line(), autocomplete_position.column() - 1 };`
	`100`	`+ Cpp::Position position { autocomplete_position.line(), autocomplete_position.column() > 0 ? autocomplete_position.column() - 1 : 0 };`
`102`	`101`
`103`	`102`	`VERBOSE("ParserAutoComplete position {}:{}", position.line, position.column);`
`104`	`103`