LibGfx: Remove ImageDecoderPlugin::initialize()

LucasChollet · AtkinsSJ · commit 4291288a3161 · 2023-07-18T14:34:35.000+01:00
No plugin is currently overriding the default implementation, which is a
no-op. So we can safely delete it.
diff --git a/Meta/Lagom/Fuzzers/FuzzBMPLoader.cpp b/Meta/Lagom/Fuzzers/FuzzBMPLoader.cpp
@@ -13,8 +13,6 @@ extern "C" int LLVMFuzzerTestOneInput(uint8_t const* data, size_t size)
     if (decoder_or_error.is_error())
         return 0;
     auto decoder = decoder_or_error.release_value();
-    if (!decoder->initialize().is_error()) {
-        (void)decoder->frame(0);
-    }
+    (void)decoder->frame(0);
     return 0;
 }
diff --git a/Meta/Lagom/Fuzzers/FuzzGIFLoader.cpp b/Meta/Lagom/Fuzzers/FuzzGIFLoader.cpp
@@ -16,9 +16,6 @@ extern "C" int LLVMFuzzerTestOneInput(uint8_t const* data, size_t size)
     if (decoder_or_error.is_error())
         return 0;
     auto decoder = decoder_or_error.release_value();
-    if (decoder->initialize().is_error()) {
-        return 0;
-    }
     auto& gif_decoder = *decoder;
     auto bitmap_or_error = decoder->frame(0);
     if (!bitmap_or_error.is_error()) {
diff --git a/Meta/Lagom/Fuzzers/FuzzICOLoader.cpp b/Meta/Lagom/Fuzzers/FuzzICOLoader.cpp
@@ -14,8 +14,6 @@ extern "C" int LLVMFuzzerTestOneInput(uint8_t const* data, size_t size)
     if (decoder_or_error.is_error())
         return 0;
     auto decoder = decoder_or_error.release_value();
-    if (!decoder->initialize().is_error()) {
-        (void)decoder->frame(0);
-    }
+    (void)decoder->frame(0);
     return 0;
 }
diff --git a/Meta/Lagom/Fuzzers/FuzzJPEGLoader.cpp b/Meta/Lagom/Fuzzers/FuzzJPEGLoader.cpp
@@ -14,8 +14,6 @@ extern "C" int LLVMFuzzerTestOneInput(uint8_t const* data, size_t size)
     if (decoder_or_error.is_error())
         return 0;
     auto decoder = decoder_or_error.release_value();
-    if (!decoder->initialize().is_error()) {
-        (void)decoder->frame(0);
-    }
+    (void)decoder->frame(0);
     return 0;
 }
diff --git a/Meta/Lagom/Fuzzers/FuzzPBMLoader.cpp b/Meta/Lagom/Fuzzers/FuzzPBMLoader.cpp
@@ -14,8 +14,6 @@ extern "C" int LLVMFuzzerTestOneInput(uint8_t const* data, size_t size)
     if (decoder_or_error.is_error())
         return 0;
     auto decoder = decoder_or_error.release_value();
-    if (!decoder->initialize().is_error()) {
-        (void)decoder->frame(0);
-    }
+    (void)decoder->frame(0);
     return 0;
 }
diff --git a/Meta/Lagom/Fuzzers/FuzzPGMLoader.cpp b/Meta/Lagom/Fuzzers/FuzzPGMLoader.cpp
@@ -14,8 +14,6 @@ extern "C" int LLVMFuzzerTestOneInput(uint8_t const* data, size_t size)
     if (decoder_or_error.is_error())
         return 0;
     auto decoder = decoder_or_error.release_value();
-    if (!decoder->initialize().is_error()) {
-        (void)decoder->frame(0);
-    }
+    (void)decoder->frame(0);
     return 0;
 }
diff --git a/Meta/Lagom/Fuzzers/FuzzPNGLoader.cpp b/Meta/Lagom/Fuzzers/FuzzPNGLoader.cpp
@@ -14,8 +14,6 @@ extern "C" int LLVMFuzzerTestOneInput(uint8_t const* data, size_t size)
     if (decoder_or_error.is_error())
         return 0;
     auto decoder = decoder_or_error.release_value();
-    if (!decoder->initialize().is_error()) {
-        (void)decoder->frame(0);
-    }
+    (void)decoder->frame(0);
     return 0;
 }
diff --git a/Meta/Lagom/Fuzzers/FuzzPPMLoader.cpp b/Meta/Lagom/Fuzzers/FuzzPPMLoader.cpp
@@ -14,8 +14,6 @@ extern "C" int LLVMFuzzerTestOneInput(uint8_t const* data, size_t size)
     if (decoder_or_error.is_error())
         return 0;
     auto decoder = decoder_or_error.release_value();
-    if (!decoder->initialize().is_error()) {
-        (void)decoder->frame(0);
-    }
+    (void)decoder->frame(0);
     return 0;
 }
diff --git a/Meta/Lagom/Fuzzers/FuzzQOILoader.cpp b/Meta/Lagom/Fuzzers/FuzzQOILoader.cpp
@@ -14,8 +14,6 @@ extern "C" int LLVMFuzzerTestOneInput(uint8_t const* data, size_t size)
     if (decoder_or_error.is_error())
         return 0;
     auto decoder = decoder_or_error.release_value();
-    if (!decoder->initialize().is_error()) {
-        (void)decoder->frame(0);
-    }
+    (void)decoder->frame(0);
     return 0;
 }
diff --git a/Meta/Lagom/Fuzzers/FuzzTGALoader.cpp b/Meta/Lagom/Fuzzers/FuzzTGALoader.cpp
@@ -14,8 +14,6 @@ extern "C" int LLVMFuzzerTestOneInput(uint8_t const* data, size_t size)
     if (decoder_or_error.is_error())
         return 0;
     auto decoder = decoder_or_error.release_value();
-    if (!decoder->initialize().is_error()) {
-        (void)decoder->frame(0);
-    }
+    (void)decoder->frame(0);
     return 0;
 }
diff --git a/Meta/Lagom/Fuzzers/FuzzWebPLoader.cpp b/Meta/Lagom/Fuzzers/FuzzWebPLoader.cpp
@@ -14,8 +14,6 @@ extern "C" int LLVMFuzzerTestOneInput(uint8_t const* data, size_t size)
     if (decoder_or_error.is_error())
         return 0;
     auto decoder = decoder_or_error.release_value();
-    if (!decoder->initialize().is_error()) {
-        (void)decoder->frame(0);
-    }
+    (void)decoder->frame(0);
     return 0;
 }
diff --git a/Tests/LibGfx/TestICCProfile.cpp b/Tests/LibGfx/TestICCProfile.cpp
@@ -25,7 +25,6 @@ TEST_CASE(png)
 {
     auto file = MUST(Core::MappedFile::map(TEST_INPUT("icc/icc-v2.png"sv)));
     auto png = MUST(Gfx::PNGImageDecoderPlugin::create(file->bytes()));
-    MUST(png->initialize());
     auto icc_bytes = MUST(png->icc_data());
     EXPECT(icc_bytes.has_value());
 
@@ -37,7 +36,6 @@ TEST_CASE(jpg)
 {
     auto file = MUST(Core::MappedFile::map(TEST_INPUT("icc/icc-v4.jpg"sv)));
     auto jpg = MUST(Gfx::JPEGImageDecoderPlugin::create(file->bytes()));
-    MUST(jpg->initialize());
     auto icc_bytes = MUST(jpg->icc_data());
     EXPECT(icc_bytes.has_value());
 
@@ -60,7 +58,6 @@ TEST_CASE(webp_extended_lossless)
 {
     auto file = MUST(Core::MappedFile::map(TEST_INPUT("icc/extended-lossless.webp"sv)));
     auto webp = MUST(Gfx::WebPImageDecoderPlugin::create(file->bytes()));
-    MUST(webp->initialize());
     auto icc_bytes = MUST(webp->icc_data());
     EXPECT(icc_bytes.has_value());
 
@@ -72,7 +69,6 @@ TEST_CASE(webp_extended_lossy)
 {
     auto file = MUST(Core::MappedFile::map(TEST_INPUT("icc/extended-lossy.webp"sv)));
     auto webp = MUST(Gfx::WebPImageDecoderPlugin::create(file->bytes()));
-    MUST(webp->initialize());
     auto icc_bytes = MUST(webp->icc_data());
     EXPECT(icc_bytes.has_value());
 
diff --git a/Tests/LibGfx/TestImageDecoder.cpp b/Tests/LibGfx/TestImageDecoder.cpp
diff --git a/Userland/Libraries/LibGUI/FileIconProvider.cpp b/Userland/Libraries/LibGUI/FileIconProvider.cpp
diff --git a/Userland/Libraries/LibGfx/ImageFormats/ICOLoader.cpp b/Userland/Libraries/LibGfx/ImageFormats/ICOLoader.cpp
diff --git a/Userland/Libraries/LibGfx/ImageFormats/ImageDecoder.cpp b/Userland/Libraries/LibGfx/ImageFormats/ImageDecoder.cpp
diff --git a/Userland/Libraries/LibGfx/ImageFormats/ImageDecoder.h b/Userland/Libraries/LibGfx/ImageFormats/ImageDecoder.h
diff --git a/Userland/Libraries/LibPDF/Filter.cpp b/Userland/Libraries/LibPDF/Filter.cpp
