Skip to content

Commit 69a3602

Browse files
supercomputer7ADKaster
authored andcommitted
Kernel/GPU: Rename GenericGraphicsAdapter => GPUDevice
GenericGraphicsAdapter is mouthful. Also, the idea is to move towards a more advanced subsystem that handles GPUs, not merely graphics adapters.
1 parent 6014ce0 commit 69a3602

14 files changed

+29
-29
lines changed

Kernel/Devices/GPU/3dfx/GraphicsAdapter.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ UNMAP_AFTER_INIT ErrorOr<bool> VoodooGraphicsAdapter::probe(PCI::DeviceIdentifie
3434
return id.vendor_id == PCI::VendorID::Tdfx && is_supported_model(id.device_id);
3535
}
3636

37-
UNMAP_AFTER_INIT ErrorOr<NonnullLockRefPtr<GenericGraphicsAdapter>> VoodooGraphicsAdapter::create(PCI::DeviceIdentifier const& pci_device_identifier)
37+
UNMAP_AFTER_INIT ErrorOr<NonnullLockRefPtr<GPUDevice>> VoodooGraphicsAdapter::create(PCI::DeviceIdentifier const& pci_device_identifier)
3838
{
3939
auto adapter = TRY(adopt_nonnull_lock_ref_or_enomem(new (nothrow) VoodooGraphicsAdapter(pci_device_identifier)));
4040
MUST(adapter->initialize_adapter(pci_device_identifier));

Kernel/Devices/GPU/3dfx/GraphicsAdapter.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,16 +9,16 @@
99
#include <AK/Types.h>
1010
#include <Kernel/Bus/PCI/Device.h>
1111
#include <Kernel/Devices/GPU/Console/GenericFramebufferConsole.h>
12-
#include <Kernel/Devices/GPU/GenericGraphicsAdapter.h>
12+
#include <Kernel/Devices/GPU/GPUDevice.h>
1313

1414
namespace Kernel {
1515

16-
class VoodooGraphicsAdapter final : public GenericGraphicsAdapter
16+
class VoodooGraphicsAdapter final : public GPUDevice
1717
, public PCI::Device {
1818

1919
public:
2020
static ErrorOr<bool> probe(PCI::DeviceIdentifier const&);
21-
static ErrorOr<NonnullLockRefPtr<GenericGraphicsAdapter>> create(PCI::DeviceIdentifier const&);
21+
static ErrorOr<NonnullLockRefPtr<GPUDevice>> create(PCI::DeviceIdentifier const&);
2222
virtual ~VoodooGraphicsAdapter() = default;
2323
virtual StringView device_name() const override { return "VoodooGraphicsAdapter"sv; }
2424

Kernel/Devices/GPU/Bochs/GraphicsAdapter.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ UNMAP_AFTER_INIT ErrorOr<bool> BochsGraphicsAdapter::probe(PCI::DeviceIdentifier
3333
return false;
3434
}
3535

36-
UNMAP_AFTER_INIT ErrorOr<NonnullLockRefPtr<GenericGraphicsAdapter>> BochsGraphicsAdapter::create(PCI::DeviceIdentifier const& pci_device_identifier)
36+
UNMAP_AFTER_INIT ErrorOr<NonnullLockRefPtr<GPUDevice>> BochsGraphicsAdapter::create(PCI::DeviceIdentifier const& pci_device_identifier)
3737
{
3838
auto adapter = TRY(adopt_nonnull_lock_ref_or_enomem(new (nothrow) BochsGraphicsAdapter(pci_device_identifier)));
3939
MUST(adapter->initialize_adapter(pci_device_identifier));

Kernel/Devices/GPU/Bochs/GraphicsAdapter.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
#include <Kernel/Bus/PCI/Device.h>
1111
#include <Kernel/Devices/GPU/Bochs/Definitions.h>
1212
#include <Kernel/Devices/GPU/Console/GenericFramebufferConsole.h>
13-
#include <Kernel/Devices/GPU/GenericGraphicsAdapter.h>
13+
#include <Kernel/Devices/GPU/GPUDevice.h>
1414
#include <Kernel/Memory/PhysicalAddress.h>
1515
#include <Kernel/Memory/TypedMapping.h>
1616

@@ -19,13 +19,13 @@ namespace Kernel {
1919
class GraphicsManagement;
2020
struct BochsDisplayMMIORegisters;
2121

22-
class BochsGraphicsAdapter final : public GenericGraphicsAdapter
22+
class BochsGraphicsAdapter final : public GPUDevice
2323
, public PCI::Device {
2424
friend class GraphicsManagement;
2525

2626
public:
2727
static ErrorOr<bool> probe(PCI::DeviceIdentifier const&);
28-
static ErrorOr<NonnullLockRefPtr<GenericGraphicsAdapter>> create(PCI::DeviceIdentifier const&);
28+
static ErrorOr<NonnullLockRefPtr<GPUDevice>> create(PCI::DeviceIdentifier const&);
2929
virtual ~BochsGraphicsAdapter() = default;
3030
virtual StringView device_name() const override { return "BochsGraphicsAdapter"sv; }
3131

Kernel/Devices/GPU/Console/Console.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99
#include <AK/AtomicRefCounted.h>
1010
#include <AK/Types.h>
11-
#include <Kernel/Devices/GPU/GenericGraphicsAdapter.h>
11+
#include <Kernel/Devices/GPU/GPUDevice.h>
1212

1313
namespace Kernel::Graphics {
1414

Kernel/Devices/GPU/GenericGraphicsAdapter.h renamed to Kernel/Devices/GPU/GPUDevice.h

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,14 +13,14 @@
1313
#include <Kernel/Memory/PhysicalAddress.h>
1414

1515
namespace Kernel {
16-
class GenericGraphicsAdapter
17-
: public AtomicRefCounted<GenericGraphicsAdapter>
18-
, public LockWeakable<GenericGraphicsAdapter> {
16+
class GPUDevice
17+
: public AtomicRefCounted<GPUDevice>
18+
, public LockWeakable<GPUDevice> {
1919
public:
20-
virtual ~GenericGraphicsAdapter() = default;
20+
virtual ~GPUDevice() = default;
2121

2222
protected:
23-
GenericGraphicsAdapter() = default;
23+
GPUDevice() = default;
2424
};
2525

2626
}

Kernel/Devices/GPU/Intel/NativeGraphicsAdapter.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ ErrorOr<bool> IntelNativeGraphicsAdapter::probe(PCI::DeviceIdentifier const& pci
3232
return is_supported_model(pci_device_identifier.hardware_id().device_id);
3333
}
3434

35-
ErrorOr<NonnullLockRefPtr<GenericGraphicsAdapter>> IntelNativeGraphicsAdapter::create(PCI::DeviceIdentifier const& pci_device_identifier)
35+
ErrorOr<NonnullLockRefPtr<GPUDevice>> IntelNativeGraphicsAdapter::create(PCI::DeviceIdentifier const& pci_device_identifier)
3636
{
3737
auto adapter = TRY(adopt_nonnull_lock_ref_or_enomem(new (nothrow) IntelNativeGraphicsAdapter(pci_device_identifier)));
3838
TRY(adapter->initialize_adapter());
@@ -67,7 +67,7 @@ ErrorOr<void> IntelNativeGraphicsAdapter::initialize_adapter()
6767
}
6868

6969
IntelNativeGraphicsAdapter::IntelNativeGraphicsAdapter(PCI::DeviceIdentifier const& pci_device_identifier)
70-
: GenericGraphicsAdapter()
70+
: GPUDevice()
7171
, PCI::Device(const_cast<PCI::DeviceIdentifier&>(pci_device_identifier))
7272
{
7373
}

Kernel/Devices/GPU/Intel/NativeGraphicsAdapter.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,12 +17,12 @@
1717
namespace Kernel {
1818

1919
class IntelNativeGraphicsAdapter final
20-
: public GenericGraphicsAdapter
20+
: public GPUDevice
2121
, public PCI::Device {
2222

2323
public:
2424
static ErrorOr<bool> probe(PCI::DeviceIdentifier const&);
25-
static ErrorOr<NonnullLockRefPtr<GenericGraphicsAdapter>> create(PCI::DeviceIdentifier const&);
25+
static ErrorOr<NonnullLockRefPtr<GPUDevice>> create(PCI::DeviceIdentifier const&);
2626

2727
virtual ~IntelNativeGraphicsAdapter() = default;
2828

Kernel/Devices/GPU/Management.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ static inline bool is_display_controller_pci_device(PCI::DeviceIdentifier const&
123123

124124
struct PCIGraphicsDriverInitializer {
125125
ErrorOr<bool> (*probe)(PCI::DeviceIdentifier const&) = nullptr;
126-
ErrorOr<NonnullLockRefPtr<GenericGraphicsAdapter>> (*create)(PCI::DeviceIdentifier const&) = nullptr;
126+
ErrorOr<NonnullLockRefPtr<GPUDevice>> (*create)(PCI::DeviceIdentifier const&) = nullptr;
127127
};
128128

129129
static constexpr PCIGraphicsDriverInitializer s_initializers[] = {

Kernel/Devices/GPU/Management.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@
1515
#include <Kernel/Bus/PCI/Definitions.h>
1616
#include <Kernel/Devices/GPU/Console/Console.h>
1717
#include <Kernel/Devices/GPU/DisplayConnector.h>
18+
#include <Kernel/Devices/GPU/GPUDevice.h>
1819
#include <Kernel/Devices/GPU/Generic/DisplayConnector.h>
19-
#include <Kernel/Devices/GPU/GenericGraphicsAdapter.h>
2020
#include <Kernel/Devices/GPU/VirtIO/GraphicsAdapter.h>
2121
#include <Kernel/Library/NonnullLockRefPtr.h>
2222
#include <Kernel/Memory/Region.h>
@@ -53,7 +53,7 @@ class GraphicsManagement {
5353

5454
void initialize_preset_resolution_generic_display_connector();
5555

56-
Vector<NonnullLockRefPtr<GenericGraphicsAdapter>> m_graphics_devices;
56+
Vector<NonnullLockRefPtr<GPUDevice>> m_graphics_devices;
5757
LockRefPtr<Graphics::Console> m_console;
5858

5959
// Note: This is only used when booting with kernel commandline that includes "graphics_subsystem_mode=limited"

0 commit comments

Comments
 (0)