Skip to content

Commit 75f2510

Browse files
committed
LibJS: Make make_super_property_reference() take a PropertyKey
Let's get rid of StringOrSymbol usage outside of Shape.
1 parent 398c181 commit 75f2510

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

Userland/Libraries/LibJS/Runtime/AbstractOperations.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -452,7 +452,7 @@ Object* get_super_constructor(VM& vm)
452452
}
453453

454454
// 13.3.7.3 MakeSuperPropertyReference ( actualThis, propertyKey, strict ), https://tc39.es/ecma262/#sec-makesuperpropertyreference
455-
ThrowCompletionOr<Reference> make_super_property_reference(GlobalObject& global_object, Value actual_this, StringOrSymbol const& property_key, bool strict)
455+
ThrowCompletionOr<Reference> make_super_property_reference(GlobalObject& global_object, Value actual_this, PropertyKey const& property_key, bool strict)
456456
{
457457
auto& vm = global_object.vm();
458458
// 1. Let env be GetThisEnvironment().

Userland/Libraries/LibJS/Runtime/AbstractOperations.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ FunctionEnvironment* new_function_environment(ECMAScriptFunctionObject&, Object*
2121
PrivateEnvironment* new_private_environment(VM& vm, PrivateEnvironment* outer);
2222
Environment& get_this_environment(VM&);
2323
Object* get_super_constructor(VM&);
24-
ThrowCompletionOr<Reference> make_super_property_reference(GlobalObject&, Value actual_this, StringOrSymbol const& property_key, bool strict);
24+
ThrowCompletionOr<Reference> make_super_property_reference(GlobalObject&, Value actual_this, PropertyKey const&, bool strict);
2525
ThrowCompletionOr<Value> require_object_coercible(GlobalObject&, Value);
2626
ThrowCompletionOr<Value> call_impl(GlobalObject&, Value function, Value this_value, Optional<MarkedValueList> = {});
2727
ThrowCompletionOr<Object*> construct(GlobalObject&, FunctionObject&, Optional<MarkedValueList> = {}, FunctionObject* new_target = nullptr);

0 commit comments

Comments
 (0)