Skip to content

Commit 99f763c

Browse files
tcl3awesomekling
authored andcommitted
usermod: Simplify uid validation
1 parent e86dd1c commit 99f763c

File tree

1 file changed

+2
-7
lines changed

1 file changed

+2
-7
lines changed

Userland/Utilities/usermod.cpp

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ ErrorOr<int> serenity_main(Main::Arguments arguments)
2727
TRY(Core::System::pledge("stdio wpath rpath cpath fattr tty"));
2828
TRY(Core::System::unveil("/etc", "rwc"));
2929

30-
int uid = 0;
30+
uid_t uid = 0;
3131
int gid = 0;
3232
bool lock = false;
3333
bool unlock = false;
@@ -75,12 +75,7 @@ ErrorOr<int> serenity_main(Main::Arguments arguments)
7575
unveil(nullptr, nullptr);
7676

7777
if (uid) {
78-
if (uid < 0) {
79-
warnln("invalid uid {}", uid);
80-
return 1;
81-
}
82-
83-
if (getpwuid(static_cast<uid_t>(uid))) {
78+
if (getpwuid(uid)) {
8479
warnln("uid {} already exists", uid);
8580
return 1;
8681
}

0 commit comments

Comments
 (0)